990496 - [Contacts] Error when user tries to cancel importing contacts

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Loli (:lolimartinezcr)]

1.4
Platform version: 30.0a2
Build ID:20140401052620
Git commit: 216cc2e5

STR
1) Tap contacts aplication.
2) Tap Settings.
3) Tap "Import Contacts" button.
4) Tap "Gmail" button -> when the import starts
5) Tap "Cancel" button
6) Tap "Error retrieving friends" screen presses "Cancel" or "Retry"

Actual result:
Back screen with "Cancel" or "Retry" buttons

Expected result:
Importing is cancelled

Comment 1

[Noemí Freire (:noemi)]

Attachment: Failing scenario

Hi,

Just adding some notes:
1) Go to Contacts -> Settings-> Import Contacts
2) Tap on Gmail
3) While obtaining the friends list tap on "Cancel" button

Actual result:
"Error retrieving friends" screen appears, after tapping on "Cancel" or "Retry" buttons, "2014-04-01-08-31-30.png" screen appears. It is necessary to kill contacts app to recover from this situation.

Expected result:
Tapping on "Cancel" should return to import contacts screen
Tapping on "Retry" should try to obtain the friends list again


The issue also occurs on the following scenarios:
Today's (4/1) master build:
Device: Hamachi
BuildId: 20140401065548
Gaia: f9a44b5
Gecko: f1b5b05
Platform version: 31.0a1

Today's (4/1) v1.3 build:
Device: Hamachi
BuildId: 20140401060114
Gaia: 24f562f
Gecko: f7ce6e6
Platform version: 28.0

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Taking a look, this looks like a pretty serious issue :(

Comment 3

[Noemí Freire (:noemi)]

Hi,

Please find a video showing the failing scenario in the following link: https://dl.dropboxusercontent.com/u/1230775/VID_0002.3gp

This issue can also appear during FTU process, in this case, users should long press "power" button and select restart or power off options to get rid of it.

Notice that the Expected Result should be that when tapping on Cancel button users should return to import contacts screen "Error retrieving friends" screen shouldn't appear under this scenario, there is no a connectivity issue, users are just cancelling the request.

Comment 4

[Noemí Freire (:noemi)]

Attachment: bug990496_logcat.txt

adding logcat traces

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 17897

This is happening not just for gmail, any other of the strategies using the import_ui will fail as well, like outlook or facebook.

Comment 6

[Jose Manuel Cantera]

Comment on attachment 8400585 [details] [review]
Pointer to PR 17897

very good work Francisco!

(I left a couple of nits in GH, and please check Travis)

thanks!

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/0a89b7371df0e96339e27dd70bf5067d7adf35b0

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Nominating to 1.3 since this can happen in the FTU, blocking the user and completely disturbing first experience.

The user will need to reboot the phone and start FTU again.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8400585 [details] [review]
Pointer to PR 17897

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Has been there forever :(
[User impact] if declined:
Huge impact, not in contacts itself but since importing is enabled in FTU, we could hang the FTU process, forcing the user to restart the phone, completely breaking user experience.
[Testing completed]:
Unit test added and passing, asking for verifyme
[Risk to taking this patch] (and alternatives if risky):
Very low, the code added is actually for performing checks, with more lines of unit tests to check the problem we were solving.
[String changes made]:

Comment 10

[Roland Kunkel [:RolandK]]

Cancelling during Gmail import returns the user back to the previous import screen. Verified as fixed for Master Buri build v1.5:

v1.5 4/3 Environmental Variables:
Device: Buri 1.5 MOZ RIL
BuildID: 20140403040201
Gaia: 0e974ff33ba47f3d1e59df1e0ad534f1bbe3ef8a
Gecko: 91be2828f17e
Version: 31.0a1
Firmware Version: V1.2-device.cfg

-

1) Verified against Master Buri build v1.5, changing status to verified.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/abc00f5e5a3130513a1a607cc422162e81bcd7e6
v1.3: https://github.com/mozilla-b2g/gaia/commit/1102392f51bed38aea42a85c4039cc1651e35bf8