Closed
Bug 990496
Opened 11 years ago
Closed 11 years ago
[Contacts] Error when user tries to cancel importing contacts
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed, b2g-v2.0 verified)
People
(Reporter: lolimartinezcr, Assigned: arcturus)
Details
Attachments
(3 files)
1.4 Platform version: 30.0a2 Build ID:20140401052620 Git commit: 216cc2e5 STR 1) Tap contacts aplication. 2) Tap Settings. 3) Tap "Import Contacts" button. 4) Tap "Gmail" button -> when the import starts 5) Tap "Cancel" button 6) Tap "Error retrieving friends" screen presses "Cancel" or "Retry" Actual result: Back screen with "Cancel" or "Retry" buttons Expected result: Importing is cancelled
Comment 1•11 years ago
|
||
Hi, Just adding some notes: 1) Go to Contacts -> Settings-> Import Contacts 2) Tap on Gmail 3) While obtaining the friends list tap on "Cancel" button Actual result: "Error retrieving friends" screen appears, after tapping on "Cancel" or "Retry" buttons, "2014-04-01-08-31-30.png" screen appears. It is necessary to kill contacts app to recover from this situation. Expected result: Tapping on "Cancel" should return to import contacts screen Tapping on "Retry" should try to obtain the friends list again The issue also occurs on the following scenarios: Today's (4/1) master build: Device: Hamachi BuildId: 20140401065548 Gaia: f9a44b5 Gecko: f1b5b05 Platform version: 31.0a1 Today's (4/1) v1.3 build: Device: Hamachi BuildId: 20140401060114 Gaia: 24f562f Gecko: f7ce6e6 Platform version: 28.0
Updated•11 years ago
|
Assignee | ||
Comment 2•11 years ago
|
||
Taking a look, this looks like a pretty serious issue :(
Assignee: nobody → francisco.jordano
Comment 3•11 years ago
|
||
Hi, Please find a video showing the failing scenario in the following link: https://dl.dropboxusercontent.com/u/1230775/VID_0002.3gp This issue can also appear during FTU process, in this case, users should long press "power" button and select restart or power off options to get rid of it. Notice that the Expected Result should be that when tapping on Cancel button users should return to import contacts screen "Error retrieving friends" screen shouldn't appear under this scenario, there is no a connectivity issue, users are just cancelling the request.
Assignee | ||
Comment 5•11 years ago
|
||
This is happening not just for gmail, any other of the strategies using the import_ui will fail as well, like outlook or facebook.
Attachment #8400585 -
Flags: review?(jmcf)
Comment 6•11 years ago
|
||
Comment on attachment 8400585 [details] [review] Pointer to PR 17897 very good work Francisco! (I left a couple of nits in GH, and please check Travis) thanks!
Attachment #8400585 -
Flags: review?(jmcf) → review+
Assignee | ||
Updated•11 years ago
|
Flags: in-testsuite+
Assignee | ||
Comment 7•11 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/0a89b7371df0e96339e27dd70bf5067d7adf35b0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
blocking-b2g: --- → 1.3?
Updated•11 years ago
|
Target Milestone: --- → 1.4 S5 (11apr)
Assignee | ||
Comment 8•11 years ago
|
||
Nominating to 1.3 since this can happen in the FTU, blocking the user and completely disturbing first experience. The user will need to reboot the phone and start FTU again.
Updated•11 years ago
|
blocking-b2g: 1.3? → 1.3+
Assignee | ||
Comment 9•11 years ago
|
||
Comment on attachment 8400585 [details] [review] Pointer to PR 17897 NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Has been there forever :( [User impact] if declined: Huge impact, not in contacts itself but since importing is enabled in FTU, we could hang the FTU process, forcing the user to restart the phone, completely breaking user experience. [Testing completed]: Unit test added and passing, asking for verifyme [Risk to taking this patch] (and alternatives if risky): Very low, the code added is actually for performing checks, with more lines of unit tests to check the problem we were solving. [String changes made]:
Attachment #8400585 -
Flags: approval-gaia-v1.3?(release-mgmt)
Comment 10•11 years ago
|
||
Cancelling during Gmail import returns the user back to the previous import screen. Verified as fixed for Master Buri build v1.5: v1.5 4/3 Environmental Variables: Device: Buri 1.5 MOZ RIL BuildID: 20140403040201 Gaia: 0e974ff33ba47f3d1e59df1e0ad534f1bbe3ef8a Gecko: 91be2828f17e Version: 31.0a1 Firmware Version: V1.2-device.cfg - 1) Verified against Master Buri build v1.5, changing status to verified.
Updated•11 years ago
|
Attachment #8400585 -
Flags: approval-gaia-v1.3?(release-mgmt) → approval-gaia-v1.3+
Comment 11•11 years ago
|
||
v1.4: https://github.com/mozilla-b2g/gaia/commit/abc00f5e5a3130513a1a607cc422162e81bcd7e6 v1.3: https://github.com/mozilla-b2g/gaia/commit/1102392f51bed38aea42a85c4039cc1651e35bf8
Updated•11 years ago
|
status-b2g-v1.3T:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•