Closed
Bug 990552
Opened 11 years ago
Closed 11 years ago
Grant |privileged| apps use the Telephony channel by requesting the audio-channel-telephony permission
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(feature-b2g:2.0)
People
(Reporter: oteo, Assigned: ferjm)
References
Details
Attachments
(1 file)
1.33 KB,
patch
|
fabrice
:
review+
pauljt
:
review+
|
Details | Diff | Splinter Review |
In order to allow third party apps to use Telephony channel (and use headphones) it would be nice to allow privileged app to use the audio-channel-telephony
Reporter | ||
Updated•11 years ago
|
Blocks: loop_security_change
Comment 1•11 years ago
|
||
Why do you need the telephony channel to use headphones? (Im just not familiar enough with how this API works) We need to solve this problem not just for this app, but for all apps, which means solving the issue that apps might block the certified phone app from being heard. (as per my comments in bug 988427)
Assignee | ||
Comment 2•11 years ago
|
||
I think the reason is to allow Loop to use the built-in earpiece in Loop audio calls apart from the speaker and/or headphones and, more important, to mute other audio sources with lower priority (i.e. the music app playing in the background).
Updated•11 years ago
|
Flags: in-moztrap?(jsmith)
Reporter | ||
Updated•11 years ago
|
feature-b2g: --- → 2.0
Reporter | ||
Comment 3•11 years ago
|
||
The idea is that the app simply requests the telephony channel in the manifest permissions so changing the title of the bug.
Summary: Grant |privileged| apps use the Telephony channel when the microphone permission is granted to the app → Grant |privileged| apps use the Telephony channel by requesting the audio-channel-telephony permission
Assignee | ||
Comment 4•11 years ago
|
||
Assignee: nobody → ferjmoreno
Attachment #8424778 -
Flags: review?(ptheriault)
Attachment #8424778 -
Flags: review?(fabrice)
Comment 5•11 years ago
|
||
Comment on attachment 8424778 [details] [diff] [review]
v1
Review of attachment 8424778 [details] [diff] [review]:
-----------------------------------------------------------------
that's technically correct if Paul agrees with the change.
Attachment #8424778 -
Flags: review?(fabrice) → review+
Reporter | ||
Updated•11 years ago
|
Flags: needinfo?(ptheriault)
Reporter | ||
Comment 6•11 years ago
|
||
Removing needinfo to Paul as I didn't see Fernando has already asked him for revisión
Flags: needinfo?(ptheriault)
Updated•11 years ago
|
Attachment #8424778 -
Flags: review?(ptheriault) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 7•11 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S2 (23may)
Updated•11 years ago
|
Flags: in-moztrap?(jsmith)
You need to log in
before you can comment on or make changes to this bug.
Description
•