990561 - [MADAI][EmergencyCall] @2.25x assets update for Emergency Call

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[[e-mail]]

== clone from bug 984802 ==

update Emergency Call app's asset

Comment 1

[[e-mail]]

Attachment: pull request redirect to github

@2.25x resource only update.

png re-generate with tools/png_recompress.sh to shape size

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8399977 [details] [review]
pull request redirect to github

Don't know why but when I preview the file

https://github.com/gasolin/gaia/blob/issue-990561/apps/emergency-call/style/images/dialer_icon_delete%402.25x.png

it give me a broken file. It even broken after I downloaded it and opened it locally.

So please upload a available file and set review again.
(And the Travis has a timeout error. So maybe you can rerun the test after upload it).

Comment 3

[[e-mail]]

Thanks for checking. I double checked and checkout the branch in another gaia repo and images looks fine to me.

I think it might be github bug that can't preview/directly download image-size less than 1k?.

I'll flash to device and check if it's a right assumption.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

OK, if it's a github bug, we should fire a bug for it on GitHub...

Comment 5

[[e-mail]]

Comment on attachment 8399977 [details] [review]
pull request redirect to github

test with `GAIA_DEV_PIXELS_PER_PX=2.25 make install-gaia APP=emergency-call`

opened profile/webapps/emergency-call.../application/style/images and checked images size are 90x90 (40x40 * 2.25)
Looks fine in real device.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8399977 [details] [review]
pull request redirect to github

Confirmed. The images displayed fine on real device.

Comment 7

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/aceb1551d7072aa9feb83d58a30f3a2c90187bd7

thanks!