Closed Bug 990566 Opened 11 years ago Closed 10 years ago

Remove strings made unused by bug 738796

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 37
Iteration:
37.3 - 12 Jan

People

(Reporter: dao, Assigned: nyee, Mentored)

References

(
URL
)

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

bug-990566-fix.patch
1.08 KB, patch
dao
: review+
Details | Diff | Splinter Review
buttonForward.tooltip and buttonBack.tooltip are unused, haven't checked if there are more.
These may be used by bug 660726.
Flags: firefox-backlog?
Flags: firefox-backlog? → firefox-backlog+
Whiteboard: p=0
There's no recent progress in bug 660726. If and when that happens, it should just add the strings back as needed.
Mentor: dao
Whiteboard: p=0 → p=0 [good first bug]
I want to solve this bug. How can I start? I'm new here.
You can follow the steps at https://developer.mozilla.org/En/Simple_Firefox_build to get build Firefox locally. Please join #introduction on the Mozilla IRC network (irc.mozilla.org) and people there can help you get your build environment up and running.
Assignee: nobody → alanaribeiroramos
Status: NEW → ASSIGNED
Hi Hanna, are you still able to work on this bug?
Flags: needinfo?(alanaribeiroramos)
URL: http://mxr.mozilla.org/mozilla-centra...
Status: ASSIGNED → NEW
Flags: needinfo?(jaws)
Assignee: alanaribeiroramos → nobody
Flags: needinfo?(jaws)
Flags: needinfo?(alanaribeiroramos)
Points: --- → 1
Whiteboard: p=0 [good first bug] → [good first bug]
Is this bug assigned? I'm a newbie and I would like to fix this bug, if it is unassigned yet.
(In reply to agaurav77 from comment #6) > Is this bug assigned? I'm a newbie and I would like to fix this bug, if it > is unassigned yet. It's currently unassigned.
Dao I am new to bug fixing. What should I know beforehand? (I'm setting up a dev version according to https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites) What IRC channels should I ask help on? Thanks.
(In reply to agaurav77 from comment #8) > Dao > > I am new to bug fixing. What should I know beforehand? (I'm setting up a dev > version according to > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/ > Build_Instructions/Windows_Prerequisites) What IRC channels should I ask > help on? The #introduction channel on irc.mozilla.org should be a good place for asking for help.
I am interested in contributing to this bug. Where would the unused strings likely be?
you can use dxr (http://dxr.mozilla.org/) to search through the code base, just search for the strings reported in comment 0.
Attachment #8542656 - Flags: review?(dao)
Comment on attachment 8542656 [details] [diff] [review] bug-990566-fix.patch Thanks!
Attachment #8542656 - Flags: review?(dao) → review+
Assignee: nobody → ny.nathan.yee
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/b5753e67278c
Keywords: checkin-needed
Whiteboard: [good first bug] → [good first bug][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/b5753e67278c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][fixed-in-fx-team] → [good first bug]
Target Milestone: --- → Firefox 37
Iteration: --- → 37.3
Flags: qe-verify?
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: