990579 - [Loop] [App] Create push helper

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Borja Salguero [:borjasalguero]]

We need an easy way to retrieve the endpoint from Simple Push and handle it. 

This will be a helper which will help us on this task, and which will be included in the final code of Loop.

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8402563 [details] [review]
Pull Request

LGTM, but it would be great to have some tests before landing :)

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8402563 [details] [review]
Pull Request

LGTM, tested on a device and it seems everything works correctly. As :ferjm commened I would be nice to add some test before landing. Feel free to add them or file a follow-up bug for them.

Thanks Borja.

Comment 4

[Borja Salguero [:borjasalguero]]

Cool! After confirming that the interface is working as expected (and it seems to be easy to use!), tomorrow I'll add a bunch of tests! Thanks for the quick look!

Comment 5

[Borja Salguero [:borjasalguero]]

Comment on attachment 8402563 [details] [review]
Pull Request

Tests added!

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8402563 [details] [review]
Pull Request

Thanks!

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/f532e8f50e101d7e6cc0be2fdbcdd2cf16d5e89a