990630 - [Camera][Madai] Preview/Gallery not using thumbnail to render the image

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Diego Marcos [:dmarcos]]

Attachment: videoGallery.MOV

The full image is used instead of thumbnail. Image rendering is slow in the preview/gallery on high resolution devices (see attached video)

Comment 1

[Diego Marcos [:dmarcos]]

Attachment: Pull Request

Comment 2

[Diego Marcos [:dmarcos]]

Attachment: Pull Request

Comment 3

[David Flanagan [:djf]]

Attachment: simpler pull request

Comment 4

[David Flanagan [:djf]]

Comment on attachment 8400936 [details] [review]
Pull Request

r- because I think this is a lot more complicated than it needs to be

Comment 5

[David Flanagan [:djf]]

Justin: I just realized that my PR is incomplete.  Since I'm parsing the JPEG data when onNewMedia() I ought to reuse that when creating the thumbnail. I don't need to do that twice.  I'll update the patch, but would still be interested to know if it fixes the bug for you on hamachi.

Comment 6

[Justin D'Arcangelo [:justindarc]]

David: Just tested your patch on my hamachi and it appears to resolve the issue with the slow drawing of the previews.

I'm not getting any crashes in Camera like you were reporting, but in general, the responsiveness of the device seems to be suffering running the latest gecko. I'm not seeing any performance issues on nexus4 with latest gecko though. However, I just flashed yesterday's gecko build onto my hamachi and the sluggishness is gone, so there must be a regression somewhere in gecko since yesterday.

Anyhow, ping me when you've completed your PR and I'll go through and review it a bit more thoroughly.

Comment 7

[David Flanagan [:djf]]

I've updated the PR to remove the now unnecessary re-parse of EXIF data for thumbnail creation.

I flashed a 1.4 nightly to my hamachi and it is much stabler, so I've been able to test as well, and it seems to work for me.

Comment 8

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8400993 [details] [review]
simpler pull request

David: Looks good to me. One thing though.. It looks like Diego had updated the README in his PR to clean up a few things. Could you bring those changes over as well? I think our entire README is long overdue for a good overhaul, but it looks like there was some good information he had in there related to debugging. It would be nice to have some of these README updates in the 1.4 uplift.

Comment 9

[Justin D'Arcangelo [:justindarc]]

Attachment: patch to fix unit tests

David: With your patch, two unit tests fail because of insufficient stubbing for Blob types. To get around this (and still test the controller methods), I've attached this two-line patch. You'll need to apply this to your PR before Travis will go green.

Comment 10

[David Flanagan [:djf]]

Thanks for the review Justin, and for the test fixes.

Landed to master: https://github.com/mozilla-b2g/gaia/commit/0e974ff33ba47f3d1e59df1e0ad534f1bbe3ef8a

Comment 11

[David Flanagan [:djf]]

Bulk edit for camera bugs.

If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master.

This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530

Comment 12

[sarsenyev]

Verified the bug is no longer reproduces on the latest 1.4 and master
Image is rending fast in preview 

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140407000203
Gaia: 86de7fcce674ef6196d68e7e23552d219a3d72db
Gecko: 6e028297be14
Version: 30.0a2
Firmware Version: v1.2-device.cfg

1.5 Environmental Variables:
Device: Buri 1.5 Master
BuildID: 20140407040202
Gaia: f1a98bfaa3ab2480945bd7018831fd56c61cdc24
Gecko: 5405d6f4e3c6
Version: 31.0a1
Firmware Version: v1.2-device.cfg