990715 - Convert nsBindingManager::mWrapperTable to nsInterfaceHashtable

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[Andrew McCreight [:mccr8]]

This hash table code is pretty crusty.  Let's update it.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Remove trailing whitespace from nsBindingManager.

try run: https://tbpl.mozilla.org/?tree=Try&rev=ac53ad595257

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Inline AddObjectEntry in nsBindingManager.

There's a lot of generic hashtable methods in nsBindingManager for some reason.

Inlining them will make later transformations easier.

There are a few style nits that I leave in place when inlining, but I think all of that goes away by the end.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Inline RemoveObjectEntry in nsBindingManager. r=bholley

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 4 - Inline SetOrRemoveObject in nsBindingManager. r=bholley

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: part 5 - Convert mWrapperTable to an nsAutoPtr in nsBindingManager.

Using a raw PLDHashtable lets you represent an uninitialized hashtable by nulling out ops,
but for something higher level, you need to use an nsAutoPtr to the hash table.

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: part 6 - Convert nsBindingManager::mWrapperTable to nsInterfaceHashtable.

Comment 7

[Andrew McCreight [:mccr8]]

Thanks for the reviews.

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=17822faead4f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a81aa15cb276
https://hg.mozilla.org/mozilla-central/rev/f3385a5c9404
https://hg.mozilla.org/mozilla-central/rev/79ab60e3452d
https://hg.mozilla.org/mozilla-central/rev/23cdb58a05de
https://hg.mozilla.org/mozilla-central/rev/15142c3e8158
https://hg.mozilla.org/mozilla-central/rev/62064d7464d7