Convert nsBindingManager::mWrapperTable to nsInterfaceHashtable

RESOLVED FIXED in mozilla31

Status

()

defect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla31
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments)

This hash table code is pretty crusty.  Let's update it.
There's a lot of generic hashtable methods in nsBindingManager for some reason.

Inlining them will make later transformations easier.

There are a few style nits that I leave in place when inlining, but I think all of that goes away by the end.
Attachment #8403361 - Flags: review?(bobbyholley)
Using a raw PLDHashtable lets you represent an uninitialized hashtable by nulling out ops,
but for something higher level, you need to use an nsAutoPtr to the hash table.
Attachment #8403366 - Flags: review?(bobbyholley)
Attachment #8403363 - Flags: review?(bobbyholley)
Attachment #8403365 - Flags: review?(bobbyholley)
Attachment #8403360 - Flags: review?(bobbyholley) → review+
Attachment #8403361 - Flags: review?(bobbyholley) → review+
Attachment #8403363 - Flags: review?(bobbyholley) → review+
Attachment #8403365 - Flags: review?(bobbyholley) → review+
Attachment #8403366 - Flags: review?(bobbyholley) → review+
Attachment #8403367 - Flags: review?(bobbyholley) → review+
Version: 24 Branch → Trunk
You need to log in before you can comment on or make changes to this bug.