Closed
Bug 990715
Opened 10 years ago
Closed 10 years ago
Convert nsBindingManager::mWrapperTable to nsInterfaceHashtable
Categories
(Core :: XBL, defect)
Core
XBL
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(6 files)
15.06 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
2.76 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
1.63 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
4.55 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
6.78 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
9.32 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
This hash table code is pretty crusty. Let's update it.
Assignee | ||
Comment 1•10 years ago
|
||
try run: https://tbpl.mozilla.org/?tree=Try&rev=ac53ad595257
Attachment #8403360 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 2•10 years ago
|
||
There's a lot of generic hashtable methods in nsBindingManager for some reason. Inlining them will make later transformations easier. There are a few style nits that I leave in place when inlining, but I think all of that goes away by the end.
Attachment #8403361 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Using a raw PLDHashtable lets you represent an uninitialized hashtable by nulling out ops, but for something higher level, you need to use an nsAutoPtr to the hash table.
Attachment #8403366 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8403367 -
Flags: review?(bobbyholley)
Assignee | ||
Updated•10 years ago
|
Attachment #8403363 -
Flags: review?(bobbyholley)
Assignee | ||
Updated•10 years ago
|
Attachment #8403365 -
Flags: review?(bobbyholley)
Updated•10 years ago
|
Attachment #8403360 -
Flags: review?(bobbyholley) → review+
Updated•10 years ago
|
Attachment #8403361 -
Flags: review?(bobbyholley) → review+
Updated•10 years ago
|
Attachment #8403363 -
Flags: review?(bobbyholley) → review+
Updated•10 years ago
|
Attachment #8403365 -
Flags: review?(bobbyholley) → review+
Updated•10 years ago
|
Attachment #8403366 -
Flags: review?(bobbyholley) → review+
Updated•10 years ago
|
Attachment #8403367 -
Flags: review?(bobbyholley) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Thanks for the reviews. https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=17822faead4f
Assignee | ||
Updated•10 years ago
|
Version: 24 Branch → Trunk
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a81aa15cb276 https://hg.mozilla.org/mozilla-central/rev/f3385a5c9404 https://hg.mozilla.org/mozilla-central/rev/79ab60e3452d https://hg.mozilla.org/mozilla-central/rev/23cdb58a05de https://hg.mozilla.org/mozilla-central/rev/15142c3e8158 https://hg.mozilla.org/mozilla-central/rev/62064d7464d7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•