990797 - TPS CI errors out when trying to e-mail results

Status: RESOLVED FIXED

(Testing Graveyard :: TPS, defect)

Description

[Jonathan Griffin (:jgriffin)]

This occurs because this code tries to pull out some metadata from the logfile via regex's:

http://mxr.mozilla.org/mozilla-central/source/testing/tps/tps/testrunner.py#102

but the relevant strings have changed:

http://mxr.mozilla.org/mozilla-central/source/services/sync/tps/extensions/tps/resource/tps.jsm#567

This is admittedly probably not the best way for the e-mailer to find this information.  But, the easiest fix will be to change the regex's to match the new format.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry, that's my fault. I will have a patch ready in a bit.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Corrected parsing of results

I agree that we should find something better but lets do it once we have the new CI in place in the next couple weeks. For now this will be sufficient.

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8400482 [details] [diff] [review]
Corrected parsing of results

Review of attachment 8400482 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb9095bf362e

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cb9095bf362e

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8400482 [details] [diff] [review]
Corrected parsing of results

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 981848
User impact if declined: None, only for testing
Testing completed (on m-c, etc.): inbound, m-c
Risk to taking this patch (and alternatives if risky): None 
String or IDL/UUID changes made by this patch: None

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8400482 [details] [diff] [review]
Corrected parsing of results

[Triage Comment]
Given the low risk here and the affected on Beta, please also uplift there if it can land cleanly otherwise put up a new branch-specific patch for approval.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/018483c2e162