990809 - Tweak when sync goes into a PROLONGED_SYNC_FAILURE state.

Status: RESOLVED INVALID

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Sync is too aggressive about notifying about prolonged failures; often the user knows the machine has been offline for an extended period.

See also bug 985868 comment 2.

Off the top of my head, we could either (a) extend the period to longer than 2 weeks, or (b) tweak the algorithm such that only 14 different failure days are considered (eg, if the machine is only used twice over a 14 day period, that only counts as 2 "failure days" rather than 14.

Blocking bug 979432, even though that meta-bug calls for "removal" and this just wants to "limit"

Comment 1

[Richard Newman [:rnewman]]

Counting failing days seems like a reasonable approach. If you haven't synced, why count it as a failure?

Comment 2

[Richard Newman [:rnewman]]

Additional: make sure that Sync isn't trying to sync when the machine is offline!

Comment 3

[Mark Hammond [:markh] [:mhammond]]

(In reply to Richard Newman [:rnewman] from comment #2)
> Additional: make sure that Sync isn't trying to sync when the machine is
> offline!

What exactly does "offline" mean here?  If the user has explicitly selected "work offline" I think it is trivial (and IIUC, already handled), but the trickier situation is when we simply aren't connected to a network (or, for more cans-of-worms, connected but behind a captive portal, for example).

Comment 4

[Richard Newman [:rnewman]]

Definitely check the former, and it's worth looking into the latter. On Android we have a handy network status API, not to mention Android's help in deciding when to sync. I imagine that we should treat "you haven't been online for a week" differently to "you've been trying to sync but it hasn't worked for a week".

Comment 5

[Mark Hammond [:markh] [:mhammond]]

We no longer notify.