SlaveAPI should be more precise on request TS

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
3 years ago
2 months ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Created attachment 8400301 [details] [diff] [review]
[slaveapi] v1 timestamp

So slaveapi has results like:

    "333614032": {
      "finish_timestamp": 1396132272.172482, 
      "request_timestamp": 1395851902, 
      "start_timestamp": 1396114213.994389, 
      "state": 3, 
      "text": "Couldn't confirm shutdown."
    }, 
    "385821584": {
      "finish_timestamp": 0, 
      "request_timestamp": 1395851902, 
      "start_timestamp": 0, 
      "state": 1, 
      "text": ""
    }, 

from present fetch of http://slaveapi1.srv.releng.scl3.mozilla.com:8080/slaves/b-2008-ix-0010/actions/shutdown_buildslave

This means that we're off by days on "request" time by accident. This is due to rounding to int(). Let's fix that.
Attachment #8400301 - Flags: review?(jhopkins)
(Assignee)

Comment 1

3 years ago
Comment on attachment 8400301 [details] [diff] [review]
[slaveapi] v1 timestamp

actually no this is definitely wrong.
Attachment #8400301 - Flags: review?(jhopkins) → review-
(Assignee)

Comment 2

3 years ago
Created attachment 8400315 [details] [diff] [review]
[slaveapi] v2 timestamp

The first patch was wrong because time.time() was only ever instantiated at class instantiation not each-invocation of class.

This should fix it.
Assignee: nobody → bugspam.Callek
Attachment #8400301 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8400315 - Flags: review?(jhopkins)
Attachment #8400315 - Flags: review?(jhopkins) → review+
(Assignee)

Comment 3

3 years ago
$ git push
Counting objects: 34, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (21/21), done.
Writing objects: 100% (21/21), 2.46 KiB | 0 bytes/s, done.
Total 21 (delta 17), reused 0 (delta 0)
To ssh://gitolite3@git.mozilla.org/build/slaveapi.git
   4f63b89..8a742ec  master -> master
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Component: Tools → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.