990814 - SlaveAPI should be more precise on request TS

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Justin Wood (:Callek)]

Attachment: [slaveapi] v1 timestamp

So slaveapi has results like:

    "333614032": {
      "finish_timestamp": 1396132272.172482, 
      "request_timestamp": 1395851902, 
      "start_timestamp": 1396114213.994389, 
      "state": 3, 
      "text": "Couldn't confirm shutdown."
    }, 
    "385821584": {
      "finish_timestamp": 0, 
      "request_timestamp": 1395851902, 
      "start_timestamp": 0, 
      "state": 1, 
      "text": ""
    }, 

from present fetch of http://slaveapi1.srv.releng.scl3.mozilla.com:8080/slaves/b-2008-ix-0010/actions/shutdown_buildslave

This means that we're off by days on "request" time by accident. This is due to rounding to int(). Let's fix that.

Comment 1

[Justin Wood (:Callek)]

Comment on attachment 8400301 [details] [diff] [review]
[slaveapi] v1 timestamp

actually no this is definitely wrong.

Comment 2

[Justin Wood (:Callek)]

Attachment: [slaveapi] v2 timestamp

The first patch was wrong because time.time() was only ever instantiated at class instantiation not each-invocation of class.

This should fix it.

Comment 3

[Justin Wood (:Callek)]

$ git push
Counting objects: 34, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (21/21), done.
Writing objects: 100% (21/21), 2.46 KiB | 0 bytes/s, done.
Total 21 (delta 17), reused 0 (delta 0)
To ssh://[e-mail]/build/slaveapi.git
   4f63b89..8a742ec  master -> master