Closed
Bug 990855
Opened 11 years ago
Closed 11 years ago
Remove dom/events from local includes
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(2 files)
|
7.99 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|
22.25 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Almost all shared header files in dom/events are now exported.
So, we should remove dom/events from local includes of moz.build files.
|
Assignee | |
Comment 1•11 years ago
|
||
TextComposition.h should be exported as mozilla/TextComposition.h.
Attachment #8400459 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Now, all header files in dom/events which are needed by other modules are exported. So, no moz.build needs to include dom/events to its LOCAL_INCLUDES.
Attachment #8400460 -
Flags: review?(gps)
Attachment #8400460 -
Flags: review?(bugs)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8400460 [details] [diff] [review]
part.2 Remove dom/events from local includes of moz.build files
Review of attachment 8400460 [details] [diff] [review]:
-----------------------------------------------------------------
You don't need build peer review on changes like this.
Attachment #8400460 -
Flags: review?(gps)
|
||
Updated•11 years ago
|
Attachment #8400459 -
Flags: review?(bugs) → review+
|
|
||
Updated•11 years ago
|
Attachment #8400460 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0e7986239214
https://hg.mozilla.org/mozilla-central/rev/145bb26f6180
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•