990881 - [Brand] $BrandShortName @ CONTEXT_SAFE_MODE

Status: RESOLVED INVALID

(Mozilla Localizations :: fi / Finnish, defect)

Description

[timeless]

This report is based on LocaleView (private tool):

Package localization 'Finnish' of key CONTEXT_SAFE_MODE
uses word: $BrandShortNamein	unlike:
$BrandShortName

Request:
Please do not split $BrandShortName. Please do not add random letters to the end of it either. If you need to you can apparently do: ${BrandShortName} -- but please contact the people responsible for l10n support for confirmation.

Please keep in mind that $BrandShortName can be "Calendar" or "Sunbird" or "Mozmail" or "Thunderbird" or "Flying Falcon" or whatever.

Filing as unconfirmed because I'm guessing that $BrandShortNamein needs to be ${BrandShortName}in

Comment 1

[Ville Pohjanheimo (inactive)]

Am I understanding this correctly that variables like $BrandShortName should be separated from trailing characters with curly brackets?

If that is the case then this is clearly not clear for some programmers either, evidenced e.g. by the same file with commonly trailing colons, periods and ellipsis after variable. Are these bugs or are those characters special cases that do not need to be separated?

Comment 2

[Aki Laaksovirta]

Those trailing letters are not random - they are required by the genitive declension in Finnish. But yes, I can fix this for SeaMonkey.

Comment 3

[Ville Pohjanheimo (inactive)]

(In reply to Ville Pohjanheimo from comment #1)
> Am I understanding this correctly that variables like $BrandShortName should
> be separated from trailing characters with curly brackets?

Could l10n@ please provide detail to original bug report and reply to Comment#1 to clarify the issue. Thanks.

Comment 4

[Axel Hecht [:Pike]]

I don't remember the different variants of variables in the installer files. Rob?

Comment 5

[Robert Strong (they/them - no direct email)]

The variables used in locales are documented. Is this not what you are asking about?
http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/installer/custom.properties

Comment 6

[Robert Strong (they/them - no direct email)]

If it is in regard to whether a space is required after a var such as $BrandShortName it isn't. For example, for Nightly if $BrandShortNameMeh was in the locale file it would read as NightlyMeh

Comment 7

[Ville Pohjanheimo (inactive)]

Thanks. Closing as invalid.