990976 - [IMPORT] Move rest of dependant files to shared

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Fernando Campo (:fcampo)]

To tackle all the rest of the import bugs we need first to move the files to shared, and later we'll do the same with functionality

Comment 1

[Fernando Campo (:fcampo)]

Morphing the bug title to include the helping libraries, styles, css and locales needed for the import, but unrelated to specific import process.

Comment 2

[Fernando Campo (:fcampo)]

Attachment: Link to PR - https://github.com/mozilla-b2g/gaia/pull/18083

Reviews for FTU, Contacts, and locales (I'm not sure if I need l10n revision for this, not a string change, but moving some strings to different files).

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8403350 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/18083

This should work for l10n seamlessly. I don't think we need to invest deeply into the 5 strings here in terms of string re-use, too.

Moving this to a f+, as that's more of what I did.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8403350 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/18083

Left some comments on github, not serious but would like to have some clarification on them.

Looking good to me, please flag me once github comments are addressed.

Thanks!

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8403350 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/18083

Thanks for the clarifications, looking good to me the FTU part, just take a look to Jose's comment about linking.

r+plusing.

Merge once other comments are fixed and travis is green ;)

Thanks Fernando!

Comment 6

[Jose Manuel Cantera]

Comment on attachment 8403350 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/18083

thanks Fernando, we can land

Comment 7

[Jose Manuel Cantera]

landed in master: 

https://github.com/fcampo/gaia/commit/cd47fd3668fa4d844aab26a51085a66eef068fda