Closed
Bug 990977
Opened 11 years ago
Closed 11 years ago
Sponsored tiles: don't expose explanation URL as a localizable string
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 31
People
(Reporter: flod, Assigned: mzhilyaev)
References
()
Details
(Whiteboard: p=2 s=it-31c-30a-29b.2 [qa-])
Attachments
(1 file)
1.97 KB,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #974745 +++ http://hg.mozilla.org/mozilla-central/diff/f3c44cfc3900/browser/locales/en-US/chrome/browser/newTab.dtd SUMO URL is currently exposed as a localizable item: this is not needed. SUMO will take care of redirecting users to the correct localization, if available, no point in having this link as a string in the .dtd file. Also, with the current status, we would need a new string every time we need to update this URL, and it wouldn't be possible on Aurora or Beta.
Updated•11 years ago
|
Flags: firefox-backlog?
Updated•11 years ago
|
Flags: firefox-backlog? → firefox-backlog+
Updated•11 years ago
|
Assignee: nobody → mzhilyaev
Whiteboard: p=2
Updated•11 years ago
|
Status: NEW → ASSIGNED
Whiteboard: p=2 → p=2 s=it-31c-30a-29b.2
Updated•11 years ago
|
Whiteboard: p=2 s=it-31c-30a-29b.2 → p=2 s=it-31c-30a-29b.2 [qa-]
Assignee | ||
Comment 1•11 years ago
|
||
Which support URL i should be using to access the explanation page on SUMO? The common pattern in to point to a SUMO page within a browser is to use a short cut as, for example, in this link: https://support.mozilla.org/1/firefox/31.0a1/Darwin/en-US/social-api, Which gets redirected to https://support.mozilla.org/en-US/kb/add-social-features-your-browser?redirectlocale=en-US&as=u&redirectslug=firefox-services-add-social-features-your-browser&utm_source=inproduct I currently use "how-do-sponsored-tiles-work" string to form this SUMO url: https://support.mozilla.org/1/firefox/31.0a1/Darwin/en-US/how-do-sponsored-tiles-work And I get "Page-not-found". So, which string I should be using instead of "how-do-sponsored-tiles-work" to get a proper SUMO page?
Flags: needinfo?(francesco.lodolo)
Comment 2•11 years ago
|
||
https://support.mozilla.org/kb/how-do-sponsored-tiles-work is already the URL for the localized page.
Flags: needinfo?(francesco.lodolo)
Reporter | ||
Comment 3•11 years ago
|
||
What I'm saying is that localizers won't need to change it, so no point in exposing it in the .properties file, just hard-code it. To give you an example (this page about Sponsored tiles doesn't seem to be localized yet). If I visit this URL https://support.mozilla.org/kb/how-download-and-install-firefox-windows I get automatically redirected to https://support.mozilla.org/it/kb/Installare%20Firefox%20su%20Windows because I'm using a browser set to Italian and the localized page is available.
Updated•11 years ago
|
Comment 4•11 years ago
|
||
Attachment #8403602 -
Flags: review?(adw)
Updated•11 years ago
|
Attachment #8403602 -
Flags: review?(adw) → review+
Updated•11 years ago
|
Component: Tabbed Browser → General
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6367da464037
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•