990979 - about:welcomeback is missing a CSS file on aero variant of the Windows theme

Status: VERIFIED FIXED

(Firefox :: Migration, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Someone forgot to add aboutWelcomeback.css to the aero section of jar.mn :)

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8400477 [details] [diff] [review]
Patch v1

Gijs is away still I think. I believe I reviewed this… oops.

Comment 3

[Matthew N. [:MattN]]

It would be nice to uplift this as I believe it's replacing the warning icon with an info one and I don't think the warning icon is very friendly to users who just did a reset.

Comment 4

[:Gijs (out for now; he/him)]

:-(

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/7629b0acbed9

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7629b0acbed9

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8400477 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 833943
User impact if declined: Confusing icon in about:welcomeback (warning icon instead of info icon) on Windows (Vista and newer)
Testing completed (on m-c, etc.): Manual testing on Nightly
Risk to taking this patch (and alternatives if risky): Extremely minimal - it's only a packaging change
String or IDL/UUID changes made by this patch: None

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cd225df4767b
https://hg.mozilla.org/releases/mozilla-beta/rev/31aca79a5126

Manual verification will just involve manually opening about:welcomeback, and checking if the icon at the top of the page is an information icon instead of a warning icon.

Comment 9

[Vuyisile Ndlovu [:terrameijar]]

Verified Fixed on Windows 8 64 Bit, Firefox 31 (2014-04-15)

Comment 10

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

(In reply to Vuyisile Ndlovu [:terrameijar] from comment #9)
> Verified Fixed on Windows 8 64 Bit, Firefox 31 (2014-04-15)

Vuyisile, could you also verify this with the latest Firefox 29 (http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/29.0b8/) and latest Firefox 30 (http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-aurora/)?

Comment 11

[Vuyisile Ndlovu [:terrameijar]]

Ok I'll do that just now

Comment 12

[Vuyisile Ndlovu [:terrameijar]]

I've verified this as fixed against Firefox 29 and 30.

Comment 13

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

(In reply to Vuyisile Ndlovu [:terrameijar] from comment #12)
> I've verified this as fixed against Firefox 29 and 30.

Marking as verified... thanks Vuyisile.