990983 - guess.msvc.bat may not detect SDK install path on 32-bit OS

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Makoto Kato [:m_kato]]

When talking with masayuki, he says, "the latest guess-msvc.bat doesn't work well on Console2".

GUID into Installed Product key seems to be different on 32bit key vs 64bit key.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: use 32bit key instead

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 8400484 [details] [diff] [review]
use 32bit key instead

32-bit process use another key for installation.  So we should use 32-bit instead for 32-bit OS or 32-bit process.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8400484 [details] [diff] [review]
use 32bit key instead

Good call, thanks. Sorry for the review lag :(

I'm probably going to spin a new release for this and bug 1014633, so please land at your convenience.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

One question though, what will the WinXP version of reg do with the /reg:32 switch? Hopefully silently ignore it?

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Maybe we can just re-use the %WIN64% logic from earlier in guess-msvc.bat instead?

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8400484 [details] [diff] [review]
use 32bit key instead

The more I think about it, the more I think comment 5 is the way to go. Sorry for the churn :(

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Taking because I'd like to get this fixed for the next release.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Attachment: Use %WIN64% conditionals instead

This is what I had in mind instead to avoid relying on /REG:32. I've confirmed that my x64 OS still works correctly, but would love some feedback from 32-bit users that this works.

Comment 9

[Bob Clary [:bc] (inactive)]

Comment on attachment 8454166 [details] [diff] [review]
Use %WIN64% conditionals instead

I successfully detected Windows SDK 8.1 over 8.0 or 7.0 and did not used the bundled SDK in MSVC 2010. My preliminary clobber builds on win32 nightly with disable gamepad and disable webgl completed fine. I've removed the disable gamepad and disable webgl and am doing another clobber build, but this looks good.

Comment 10

[Bob Clary [:bc] (inactive)]

paolo, I'll attach the updated batch files that allowed me to build on win7 32bit.

Comment 11

[Bob Clary [:bc] (inactive)]

Attachment: guess-msvc.bat

Comment 12

[Bob Clary [:bc] (inactive)]

Attachment: start-shell-msvc2010.bat

Comment 13

[:Paolo Amadini]

(In reply to Bob Clary [:bc:] from comment #10)
> paolo, I'll attach the updated batch files that allowed me to build on win7 32bit.

Thank you! Do they contain more changes than attachment 8454166 [details] [diff] [review]? I don't use the Windows 8 SDK so the attached patch alone should not have any effect, while it seemed by reading comment 9 that it solved your issues.

I can try the batch files in a few minutes if they are relevant (I'm trying to build an older changeset right now to verify if the issue goes away).

Comment 14

[Bob Clary [:bc] (inactive)]

The guess-msvc.bat is the result of applying the patch, but start-shell-msvc2010.bat is from the tip of the mozilla-build repo. If you don't have Windows 8 SDK you won't be able to build. You will need to disable gamepad in any event but the current build situation with Angle will still prevent you from building if you only have Windows 7 SDK/VS 2010 built in SDK and the June 2010 DirectX SDK. At least that is my understanding.

Comment 15

[Joel Rocha]

could it be because after this block:
rem The call to VS 2010 vcvars32 adds 7.x SDK paths, so prepend the 8.0 kit to give it priority
if "%SDKVER%"=="8" (
...
)

You have another block that does this:
if "%VC10DIR%"=="" (
    rem Prepend SDK paths - Don't use the SDK SetEnv.cmd because it pulls in

This means that even if you have Win8.x SDK but you only have VS2010 installed you won't be able to build using the Win8.x SDK?

Comment 16

[Joel Rocha]

Maybe the second block removes the priority given by the first block? (i'm just guessing...)

Comment 17

[Joel Rocha]

In the first message, were it reads VS2010 i meant VS Express 2010.

Comment 18

[:Paolo Amadini]

(In reply to Joel Rocha from comment #15)
> This means that even if you have Win8.x SDK but you only have VS2010
> installed you won't be able to build using the Win8.x SDK?

Yeah, as noted in bug 1010371 comment 31, from my understanding the Windows 7 SDK must be used when you build on Visual Studio 2010 Express. This probably means we should find a different way to solve the build issues there.

Comment 19

[:Paolo Amadini]

I'll be available for more debugging and help next week.

Comment 20

[Joel Rocha]

I think there is no need.(In reply to :Paolo Amadini from comment #18)
> (In reply to Joel Rocha from comment #15)
> > This means that even if you have Win8.x SDK but you only have VS2010
> > installed you won't be able to build using the Win8.x SDK?
> 
> Yeah, as noted in bug 1010371 comment 31, from my understanding the Windows
> 7 SDK must be used when you build on Visual Studio 2010 Express. This
> probably means we should find a different way to solve the build issues
> there.

There is no need to 'find a way'. I think i'll solve this with my proposal at https://bugzilla.mozilla.org/show_bug.cgi?id=691292

If someone could check that out and give me some feedback that would be great, otherwise i'll try to sync my code with this changes, as Ryan already told me that this changes will land first than mine.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

I'm very much open to further improvements to these files, but let's do follow-up work in new bugs. The patch here is confirmed to work and I don't want to block getting this fixed for users on the "perfect" fix.

http://hg.mozilla.org/mozilla-build/rev/60154af072fc

Comment 22

[Robert Longson [:longsonr]]

I've tried the 2 files in this bug and there's no change for me. Is there any more information I could provide?

Comment 23

[Robert Longson [:longsonr]]

I've managed to disable enough of angle that my build now completes.