990998 - Invalid radio state change handler

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[:gerard-majax]

Working on bug 989926 exposed an issue with the System app radio state change handler.
Symptom is this output:
JavaScript error: app://system.gaiamobile.org/js/radio.js, line 126: this._doSetRadioEnabled is not a function

I don't have a clear idea of the impact, but this has been introduced in bug 960861.

Comment 1

[:gerard-majax]

Attachment: Link to Github https://github.com/mozilla-b2g/gaia/pull/17895

Please find attached a pull request that fixes the issue.

Comment 2

[:gerard-majax]

Travis is green at: https://travis-ci.org/mozilla-b2g/gaia/builds/22095540

Comment 3

[:gerard-majax]

Comment on attachment 8400574 [details] [review]
Link to Github https://github.com/mozilla-b2g/gaia/pull/17895

Forwarding

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8400574 [details] [review]
Link to Github https://github.com/mozilla-b2g/gaia/pull/17895

Sorry for the late reply because I just came back from vacation ! 

It's a good catch by the way, I didn't notice the scope problem when copy / paste related codes from airplane_mode.js to radio.js. 

Because I am not the owner / peer of System app, basically it is f+ for me.

Let me forward this to Alive to give you a quick review. Thanks Alexandre :)

Comment 5

[:gerard-majax]

Thanks. I addressed the nits :)

Comment 6

[:gerard-majax]

Travis is green: https://travis-ci.org/mozilla-b2g/gaia/builds/22420920

Comment 7

[:gerard-majax]

https://github.com/mozilla-b2g/gaia/commit/c2b5d6d41bb2ea58c327c6f69a7568df218c081b

Comment 9

[Jason Smith [:jsmith]]

Per the dupe, this is also needed on 1.4, so moving to 1.4+.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/324f061632a8e696e2fe94a234be91aa330e14d9