Closed Bug 991016 Opened 11 years ago Closed 9 years ago

CID 1136444: Unchecked return value in jswrapper.cpp as found by Coverity

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: gkw, Assigned: jorendorff)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, regression)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #991012 +++ Coverity analysis of source code in js/src has found an Unchecked return value issue, that probably happened in the past month. ________________________________________________________________________________________________________ *** CID 1136444: Unchecked return value (CHECKED_RETURN) /js/src/jswrapper.cpp: 597 in js::CrossCompartmentWrapper::getPrototypeOf(JSContext *, JS::Handle<JSObject *>, JS::MutableHandle<JSObject *>)() 591 { 592 RootedObject wrapped(cx, wrappedObject(wrapper)); 593 AutoCompartment call(cx, wrapped); 594 if (!JSObject::getProto(cx, wrapped, protop)) 595 return false; 596 if (protop) >>> CID 1136444: Unchecked return value (CHECKED_RETURN) >>> No check of the return value of "protop->setDelegate(cx)". 597 protop->setDelegate(cx); 598 } 599 600 return cx->compartment()->wrap(cx, protop); 601 } 602 jorendorff, any thoughts on how to move forward here?
Flags: needinfo?(jorendorff)
Summary: Unchecked return value in jswrapper.cpp as found by Coverity → CID 1136444: Unchecked return value in jswrapper.cpp as found by Coverity
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Flags: needinfo?(jorendorff)
Comment on attachment 8726853 [details] [diff] [review] Check return value of a setDelegate call Review of attachment 8726853 [details] [diff] [review]: ----------------------------------------------------------------- APPROVED.
Attachment #8726853 - Flags: review?(efaustbmo) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: