991016 - CID 1136444: Unchecked return value in jswrapper.cpp as found by Coverity

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

+++ This bug was initially created as a clone of Bug #991012 +++

Coverity analysis of source code in js/src has found an Unchecked return value issue, that probably happened in the past month.


________________________________________________________________________________________________________
*** CID 1136444:  Unchecked return value  (CHECKED_RETURN)
/js/src/jswrapper.cpp: 597 in js::CrossCompartmentWrapper::getPrototypeOf(JSContext *, JS::Handle<JSObject *>, JS::MutableHandle<JSObject *>)()
591         {
592             RootedObject wrapped(cx, wrappedObject(wrapper));
593             AutoCompartment call(cx, wrapped);
594             if (!JSObject::getProto(cx, wrapped, protop))
595                 return false;
596             if (protop)
>>>     CID 1136444:  Unchecked return value  (CHECKED_RETURN)
>>>     No check of the return value of "protop->setDelegate(cx)".
597                 protop->setDelegate(cx);
598         }
599     
600         return cx->compartment()->wrap(cx, protop);
601     }
602     


jorendorff, any thoughts on how to move forward here?

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Check return value of a setDelegate call

Comment 2

[Eric Faust [:efaust]]

Comment on attachment 8726853 [details] [diff] [review]
Check return value of a setDelegate call

Review of attachment 8726853 [details] [diff] [review]:
-----------------------------------------------------------------

APPROVED.

Comment 3

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c57c2afe55b4952454821fea813ddc1d829cd8d
Bug 991016 - Check return value of a setDelegate call. r=efaust.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4c57c2afe55b