991028 - Get rid of AutoOpenSurface

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Get rid of AutoOpenSurface

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Make ContentClientIncremental stop using OpenDescriptor

Moz2D!

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Get rid of Open/CloseDescriptor

Comment 4

[Nicolas Silva [:nical]]

Comment on attachment 8400560 [details] [diff] [review]
Get rid of AutoOpenSurface

Review of attachment 8400560 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ImageDataSerializer.h
@@ +90,5 @@
>      Validate();
>    }
> +
> +  ImageDataDeserializer()
> +    : ImageDataSerializerBase(nullptr, 0)

nit: remove this

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Remove unnecessary IPDL types

Comment 6

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/780bec5571b9
https://hg.mozilla.org/integration/mozilla-inbound/rev/6dc852777a4d
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5bacc566e58
https://hg.mozilla.org/integration/mozilla-inbound/rev/147581a518c3

Comment 7

[Phil Ringnalda (:philor)]

Backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/2579095d0f7e after Mac nonunified asked the musical question "did you mean 'gfx::SurfaceFormat'?" in https://tbpl.mozilla.org/php/getParsedLog.php?id=37349946&tree=Mozilla-Inbound

Comment 8

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41d045863cbf
https://hg.mozilla.org/integration/mozilla-inbound/rev/4937c83749e4
https://hg.mozilla.org/integration/mozilla-inbound/rev/4568d98ca5f9
https://hg.mozilla.org/integration/mozilla-inbound/rev/814f77d08ee7

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/41d045863cbf
https://hg.mozilla.org/mozilla-central/rev/4937c83749e4
https://hg.mozilla.org/mozilla-central/rev/4568d98ca5f9
https://hg.mozilla.org/mozilla-central/rev/814f77d08ee7