stop importing WithProperties in buildbot-configs

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
Last year

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

In the mozilla-tests configs we import WithProperties in config_common. Because of this, you can't evaluate these configs without having Buildbot installed. For bugs like 989492, this means a lot of additional dependencies (twisted, python-mysql, etc.)

Turns out that the only thing we do with WithProperties it put it in TALOS_CMD, which is copied into talos_command:
https://mxr.mozilla.org/build-central/search?string=WithProperties&find=%2Fbuildbot-configs%2Fmozilla&findi=&filter=^[^\0]*%24&hitlimit=&tree=build-central
https://mxr.mozilla.org/build-central/search?string=TALOS_CMD

Which is only used once, when we pass it to the factory in misc.py:
https://mxr.mozilla.org/build-central/search?string=talos_command

Which means that we can just drop the WithProperties from buildbot-configs and add it in buildbotcustom instead. These patches do that.

I ran a dump_master.py before and after, and there's no differences.
Attachment #8400626 - Flags: review?(catlee)
Assignee: nobody → bhearsum
Attachment #8400627 - Flags: review?(catlee)
Blocks: 989492
Attachment #8400626 - Flags: review?(catlee) → review+
Attachment #8400627 - Flags: review?(catlee) → review+
Attachment #8400627 - Flags: checked-in+
Attachment #8400626 - Flags: checked-in+
in production.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.