Closed Bug 991088 Opened 10 years ago Closed 10 years ago

Fix test_system_notification_bar.py

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: RobertC, Assigned: RobertC)

Details

Attachments

(2 files)

The test is failing on latest build because at one point we are waiting for the notification container to appear at location y = 54. In the last build the container appears at location y = 50.

Traceback (most recent call last):
  File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette_test.py", line 163, in run
    testMethod()
  File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/tests/python/gaia-ui-tests/gaiatest/tests/functional/system/test_system_notification_bar.py", line 30, in test_notification_bar
    utility_tray.wait_for_notification_container_displayed()
  File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/tests/python/gaia-ui-tests/gaiatest/apps/system/regions/utility_tray.py", line 18, in wait_for_notification_container_displayed
    self.wait_for_condition(lambda m: m.find_element(*self._notification_container_locator).location['y'] == 54)
  File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 54, in wait_for_condition
    Wait(self.marionette, timeout).until(method, message=message)
  File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/wait.py", line 143, in until
    cause=last_exc)
TimeoutException: TimeoutException: Timed out after 30.0366649628 seconds
TEST-UNEXPECTED-FAIL | test_system_notification_bar.py test_system_notification_bar.TestNotificationBar.test_notification_bar

build info:
Gaia      6274b3645b3d41df4aa5a55398b5d106edf1c528
Gecko     https://hg.mozilla.org/mozilla-central/rev/4941a2ac0786
BuildID   20140402040201
Version   31.0a1
ro.build.version.incremental=eng.tclxa.20131223.163538
ro.build.date=Mon Dec 23 16:36:04 CST 2013
Attached file Pull request
I added a PR with the change from 54 to 50, but before merging I would like Jason to see if this is an intended change or a bug.

The error appeared after opening the utility tray. The notification is present, but it has a different location.
Attachment #8400681 - Flags: review?(florin.strugariu)
Attachment #8400681 - Flags: review?(bob.silverberg)
Attachment #8400681 - Flags: feedback?(jsmith)
Comment on attachment 8400681 [details] [review]
Pull request

I need to see manual testing on the bug to prove this. Pointing me at a patch here is going to help identify there's a real bug here or not.
Attachment #8400681 - Flags: feedback?(jsmith)
Comment on attachment 8400681 [details] [review]
Pull request

looks good to me if the changes are intended! :)
Attachment #8400681 - Flags: review+
(In reply to Jason Smith [:jsmith] from comment #2)
> Comment on attachment 8400681 [details] [review]
> Pull request
> 
> I need to see manual testing on the bug to prove this. Pointing me at a
> patch here is going to help identify there's a real bug here or not.

Seems like the notification bar is smaller then before.
(In reply to [:AndreiH] from comment #4)
> (In reply to Jason Smith [:jsmith] from comment #2)
> > Comment on attachment 8400681 [details] [review]
> > Pull request
> > 
> > I need to see manual testing on the bug to prove this. Pointing me at a
> > patch here is going to help identify there's a real bug here or not.
> 
> Seems like the notification bar is smaller then before.

Can you include a screenshot?
There where changes in the notification area so it looks like this is valid

https://github.com/mozilla-b2g/gaia/pull/17835/files#diff-335953a0df10e3fb9613930bca786abfL8
test_quick_settings_button fails for the same reason can you also modify that?
The PR should fix both tests as they use the same object.
Ok - this looks like expected change then from the window management refactoring work.
Attachment #8400681 - Flags: review?(florin.strugariu) → review+
https://github.com/mozilla-b2g/gaia/commit/f2bc308b9eaf3abacac8f05516aac6a7be4032ae
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #8400681 - Flags: review?(bob.silverberg)
backed out for https://travis-ci.org/mozilla-b2g/gaia/jobs/22166970 - was requested in #gaia
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
So this was resolved right? Test is not failing anymore :)
Flags: needinfo?(cbook)
(In reply to [:AndreiH] from comment #13)
> So this was resolved right? Test is not failing anymore :)

well Bebe/Florin asked me to do the backout so the codechange done in comment #11 was reverted/backedout - i guess Florin can speak more about the current state
Flags: needinfo?(cbook) → needinfo?(florin.strugariu)
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: