991090 - [Camera] "Options" is not localizable

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Francesco Lodolo [:flod]]

I'm currently testing master with the new Camera: the main title "Options" is not available in the .properties file, therefore it's not localized.

Not sure if it's just the string missing or need to be fixed in the code as well.

Comment 1

[Théo Chevalier]

Oops, didn't even notice since we use the same word in French :\

Looks hardcoded, yes:

in apps/camera/js/views/settings.js

line 95:        '<h2 class="settings_title">Options</h2>' +

Comment 2

[Francesco Lodolo [:flod]]

Right
https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/views/settings.js#L95

Wilson, can you help me out or direct me to the right person for this question? I'm not familiar with the approach.

Take for example this line
https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/config/settings.js#L59

Is this "back" a l10n-id that should be available in the .properties file?

Comment 3

[Wilson Page [:wilsonpage]]

Sure I can take this.

The 'back' title is actually never displayed. We should probably remove it to avoid confusion.

Comment 4

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 8400736 [details] [review]
pull-request (master)

Looks good to me. Can you make sure other strings in there are not actually used?

Comment 6

[Wilson Page [:wilsonpage]]

Removed additional unused keys from config/settings.js

Comment 7

[Wilson Page [:wilsonpage]]

Landed on 'master': https://github.com/mozilla-b2g/gaia/commit/99c3fd7a68790173939b9df891c7a8b384c613d4

Comment 8

[David Flanagan [:djf]]

Bulk edit for camera bugs.

If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master.

This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530

Comment 9

[sarsenyev]

Verified the bug is fixed on 1.4 and master
the "Options"  in camera is localizable now.

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140407000203
Gaia: 86de7fcce674ef6196d68e7e23552d219a3d72db
Gecko: 6e028297be14
Version: 30.0a2
Firmware Version: v1.2-device.cfg

1.5 Environmental Variables:
Device: Buri 1.5 MOZ
BuildID: 20140407040202
Gaia: f1a98bfaa3ab2480945bd7018831fd56c61cdc24
Gecko: 5405d6f4e3c6
Version: 31.0a1
Firmware Version: v1.2-device.cfg