991114 - [Contacts] Invalid text when user delete multiple contacts

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Loli (:lolimartinezcr)]

Today's (4/2) master build:
Device: Hamachi
BuildId: 20140401065548
Gaia: f9a44b5
Gecko: f1b5b05
Platform version: 31.0a1

Reproducible 100%

Pre-requisites:
Saved contacts

STR
1) Tap Contacts aplication.
2) Tap on "Settings".
3) Tap "Delete Contacts" button.
4) Tap "Select all" button.

Actual result:
Screen attached with title "The page at app://communications.gaiamobile.org says"

Expected result:
Screen attached with valid title.

Comment 1

[Loli (:lolimartinezcr)]

Attachment: 2014-04-02-11-05-49.png

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.5+ to make sure this is fixed for a newly landed feature

Comment 3

[Oleg Zasypkin [:azasypkin]]

Some updates:

It looks like a common problem for all apps that use "entry_points" in manifest. Regarding this particular case, originally contacts app has "app.config.origin" that is equal to "http://communications.gaiamobile.org:8080". In [1] it becomes equal to "http://communications.gaiamobile.org:8080/contacts/index.html". 

When alert\prompt\... is called it's caught by [2] where "evt.detail.title" initially is set to "The page at http://communications.gaiamobile.org:8080 says:". Afterwards there is an attempt to make title more useful at [3] and here we'll literally have:

"'The page at http://communications.gaiamobile.org:8080 says:'.contains('http://communications.gaiamobile.org:8080/contacts/index.html')" that can't be true for both "config.url" and "config.origin".

Hey Ghislain, as you created this title extraction code, could you please advise on what b2g\gaia part doesn't work correctly here?

[1] https://github.com/mozilla-b2g/gaia/blob/33b5bcb1a092172c983ef178766869aba738ad4d/apps/system/js/browser_config_helper.js#L70
[2] https://github.com/mozilla-b2g/gaia/blob/33b5bcb1a092172c983ef178766869aba738ad4d/apps/system/js/app_modal_dialog.js#L26
[3] https://github.com/mozilla-b2g/gaia/blob/33b5bcb1a092172c983ef178766869aba738ad4d/apps/system/js/app_modal_dialog.js#L455-L459

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

triage: obvious UI problem, this stays as 2.0+

Comment 6

[Noemí Freire (:noemi)]

As mentioned by Cristian in https://bugzilla.mozilla.org/show_bug.cgi?id=1000756#c0, there is 2 UI issues to be solved here:
1) "The page at app://communications.gaiamobile.org says:" like title
2) Cancel | OK (blue - recommendation) buttons. These should be Cancel | Remove (red - danger)

Comment 7

[Cristian Rodriguez (:crdlc)]

Attachment: 18632.html

Thanks for your review

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8411695 [details]
18632.html

Amazing work, tested and working perfect

Comment 9

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/d9490266f44f5727566a942e290e138f2f90823a

Comment 10

[Aus Lacroix [:aus]]

(In reply to Oleg Zasypkin [:azasypkin] from comment #3)
> When alert\prompt\... is called it's caught by [2] where "evt.detail.title"
> initially is set to "The page at http://communications.gaiamobile.org:8080
> says:". Afterwards there is an attempt to make title more useful at [3] and
> here we'll literally have:
> 
> "'The page at http://communications.gaiamobile.org:8080
> says:'.contains('http://communications.gaiamobile.org:8080/contacts/index.
> html')" that can't be true for both "config.url" and "config.origin".
> 
> Hey Ghislain, as you created this title extraction code, could you please
> advise on what b2g\gaia part doesn't work correctly here?

Oleg, that'd be an issue with the code I wrote, unfortunately. It should test for the scheme + host part of the URL but not it's full path. The code as written works for single origin applications but not for multi-app in one (such as contacts!). If you could file a bug and CC me on it I'll bring it up in the Systems FE triage next week.

Comment 11

[Oleg Zasypkin [:azasypkin]]

(In reply to Ghislain Aus Lacroix [:aus] from comment #10)
> (In reply to Oleg Zasypkin [:azasypkin] from comment #3)
> > When alert\prompt\... is called it's caught by [2] where "evt.detail.title"
> > initially is set to "The page at http://communications.gaiamobile.org:8080
> > says:". Afterwards there is an attempt to make title more useful at [3] and
> > here we'll literally have:
> > 
> > "'The page at http://communications.gaiamobile.org:8080
> > says:'.contains('http://communications.gaiamobile.org:8080/contacts/index.
> > html')" that can't be true for both "config.url" and "config.origin".
> > 
> > Hey Ghislain, as you created this title extraction code, could you please
> > advise on what b2g\gaia part doesn't work correctly here?
> 
> Oleg, that'd be an issue with the code I wrote, unfortunately. It should
> test for the scheme + host part of the URL but not it's full path. The code
> as written works for single origin applications but not for multi-app in one
> (such as contacts!). If you could file a bug and CC me on it I'll bring it
> up in the Systems FE triage next week.

Sure, filed a bug 1001269.

Thanks!

Comment 12

[Loli (:lolimartinezcr)]

Tested and working
1.5
Hamachi
Gecko: 7db7603
Gaia: facd91d