Closed Bug 991134 Opened 10 years ago Closed 10 years ago

Output an additional failure line for reftest/jsreftest loadfailed:null failures to make bug 789751 and bug 720452 TBPL star-able

Categories

(Testing :: Reftest, defect)

defect
Not set
normal

Tracking

(firefox30 fixed, firefox31 fixed)

RESOLVED FIXED
mozilla31
Tracking Status
firefox30 --- fixed
firefox31 --- fixed

People

(Reporter: emorley, Assigned: emorley)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I feel dirty suggesting we do this, but the lack of action in bug 720452 doesn't leave me with much other choice.

The failure modes there are not TBPL star-able, since the test name varies so much, so I propose we at least as a temporary measure output an additional failure line here:
https://hg.mozilla.org/mozilla-central/diff/5a24cad1dd8a/layout/tools/reftest/reftest.js

...that can generate a bug suggestion.
Summary: Output an addition failure line for jsreftest loadfailed:null failures to make bug 720452 TBPL star-able → Output an additional failure line for jsreftest loadfailed:null failures to make bug 720452 TBPL star-able
Blocks: 789751
Summary: Output an additional failure line for jsreftest loadfailed:null failures to make bug 720452 TBPL star-able → Output an additional failure line for reftest/jsreftest loadfailed:null failures to make bug 789751 and bug 720452 TBPL star-able
Attached patch Patch v1Splinter Review
The failure modes in bug 789751 and bug 720452 appear to affect all reftests indiscriminately, and as such the usual TBPL test filename search fails to succeed, resulting in sheriffs having to manually star the failures. 

This patch adds an additional log line for these no-reason failures, which intentionally doesn't follow the "three pipe delimeted fields" format, and so hits the TBPL fallback of searching Bugzilla for the entire line.

Now bug 896840 will hopefully add failure reasons to more of the reftest load flow, to the point where we can fix these failures - but for now making them starable would make the sheriffs significantly more happy about the current situation (and also mean more easily filterable bugspam for those two bugs for everyone else too).
Attachment #8407664 - Flags: review?(dbaron)
(Trailing semi-colon removed locally)
Comment on attachment 8407664 [details] [diff] [review]
Patch v1

r=dbaron with the double-;; fixed
Attachment #8407664 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/d849022d8633
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.