991168 - Increase the default width of the request details pane

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Victor Porof [:vporof][:vp]]

Since bug 956357 landed, the default width of the right pane isn't quite enough for all the buttons, thus the HTML button ends up being bit squished. Increasing the default width will fix this.

Comment 1

[Victor Porof [:vporof][:vp]]

This involves changing the devtools.netmonitor.panes-network-details-width pref in firefox.js to something like 550. Super easy good first bug.

Comment 2

[Praveenkumar[:speaker]]

Hi i would like to take up this bug 
i have seen the file(mozilla-central/browser/app/profile) and made the change to 550 but unable to see any size change on the width of  network monitor ( i am opening network monitor using ctrl + shift + Q )

Comment 3

[Victor Porof [:vporof][:vp]]

Hi! Thanks for the interest. That is the correct change to make.

To see the difference, navigate to a page that requests an html (which is probably easy to find :P) and inspect that request. The pane on the right should be slightly wider, and leave room for all the top buttons.

Please attach a patch and ask for review.

Comment 4

[Praveenkumar[:speaker]]

Attachment: patch for the change

I have submitted the patch for the change i have done

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8401740 [details] [diff] [review]
patch for the change

r?somebody@somewhere means "I'd like you to review this"
r+ means "this was reviewed and was deemed ready to land in the codebase"

Comment 6

[Victor Porof [:vporof][:vp]]

Comment on attachment 8401740 [details] [diff] [review]
patch for the change

Review of attachment 8401740 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
LGTM.

Comment 7

[Carsten Book [:Tomcat]]

landed on fx-team. Welcome and thanks for contributing to Mozilla!

https://hg.mozilla.org/integration/fx-team/rev/b619705ba480

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b619705ba480