991202 - The event callback of popup notifications should have a way to prevent the panel from showing

Status: VERIFIED FIXED

(Toolkit :: General, defect)

Description

[Florian Quèze [:florian]]

Attachment: Patch

This is needed for bug 974527 where we need to display an icon in the notification area of the url bar, but clicking that icon should reopen a notification bar, rather than a popup.

A few notes about the patch:
- returning true by default instead of false in the event callback of webrtc notifications was my mistake in bug 723951.
- while debugging the test I added, I noticed that a few other popupnotification tests weren't removing the notifications after they were finished. Most of these are tests I added, except "Test #29 - Popup Notifications should catch exceptions from callbacks" that's not mine.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Florin, can you assign this to someone on your team for the QA contact? Thanks!

Comment 2

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/b5bf95a06118

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b5bf95a06118

Comment 4

[Marco Mucci [:MarcoM]]

Hi Catalin, will verification of this bug be able to be completed before the end of our iteration on Monday April 14?

Comment 5

[Catalin Varga [QA][:VarCat]]

Hi Marco,

I've verified the bug using the following environment:
The trybuild provided here:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-e487810349d2/
OS: Win 7 x64, Mac Os X 10.9.2, Ubuntu 13.04 x64

I order to verify manually this bug I've used the same scenario used to verify bug 974527