99124 - when I create an ldap addressbook, it sets the filename pref to "abook.mab"

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[(not reading, please use [e-mail] instead)]

I created an ldap addressbook "test" and here are the prefs it created:

user_pref("ldap_2.servers.test.description", "test");
user_pref("ldap_2.servers.test.filename", "abook.mab");
user_pref("ldap_2.servers.test.replication.lastChangeNumber", 0);
user_pref("ldap_2.servers.test.uri", "ldap://test:389/test??sub");

the .filename pref of "abook.mab" scares me, since that's the filename for my 
personal address book.

Comment 1

[Srilatha Moturi]

I'm seeing this in my profile too. This is happening because of the code in 
nsDirPrefs.cpp.
http://lxr.mozilla.org/seamonkey/source/mailnews/addrbook/src/nsDirPrefs.cpp#288
5
By default server->position is set to 1 and so filename is being set to 
abbok.mab.
2897         /* set default personal address book file name*/
2898         if (server->position == 1)
2899             server->fileName = nsCRT::strdup(kPersonalAddressbook);

Comment 2

[scottputterman]

reassignig to cavin

Comment 3

[yulian chang]

Reassign QA contact to myself

Comment 4

[John Marmion]

I believe a good way to deal with this bug is to have a unified integrated
method of adding LDAP Address Books from the Preferences and the Address Book
UI. The proposed fix for bug #83091 attempts to deal with this.

Comment 5

[(not reading, please use [e-mail] instead)]

I believe I've fixed this.  now we should be setting the file name to something
unique.  see my recent changes to nsDirPrefs.cpp (for checkin #83091)

note to rdayal, you can now use this fileName for the local .mab that you'll
need for replication.  

you might consider investigating this:

when offline, treat all LDAPDirectory types as PABDirectory types.  see
nsDirPrefs.cpp

Comment 6

[(not reading, please use [e-mail] instead)]

taking, this got fixed with #83091

Comment 7

[(not reading, please use [e-mail] instead)]

fixed.

Comment 8

[yulian chang]

Verified