991246 - TypeError: aIdsApp is undefined at OperatorApps.jsm:317

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Gregor Wagner [:gwagner]]

Seen on nexus 4 with current trunk and --enable-debug gecko build.

*************************
A coding exception was thrown and uncaught in a Task.

Full message: TypeError: aIdsApp is undefined
Full stack: this.OperatorAppsRegistry._installOperatorApps/<@resource://gre/modules/OperatorApps.jsm:317:23
TaskImpl_run@resource://gre/modules/Task.jsm:298:1
resolve@resource://gre/modules/commonjs/sdk/core/promise.js:118:11
then@resource://gre/modules/commonjs/sdk/core/promise.js:43:43
resolve@resource://gre/modules/commonjs/sdk/core/promise.js:185:11
TaskImpl_run@resource://gre/modules/Task.jsm:307:9
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:748:11
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:627:7

*************************

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

Could you try if this patch fixes your problem?

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 3

[Gregor Wagner [:gwagner]]

The exception is gone. But we done set PREF_FIRST_RUN_WITH_SIM now. Is this what we want?

Comment 4

[Marco Castelluccio [:marco]]

Attachment: Alternative patch

I think we do want to set the pref, but I'm not sure.

Comment 6

[Jason Smith [:jsmith]]

Comment on attachment 8400892 [details] [diff] [review]
Alternative patch

Fabrice is on PTO this week.

Fernando - Can you take care of the review here?

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8400892 [details] [diff] [review]
Alternative patch

Carmen is more familiar than me with this code

Comment 8

[Carmen Jimenez Cabezas]

Comment on attachment 8400892 [details] [diff] [review]
Alternative patch

Review of attachment 8400892 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/apps/src/OperatorApps.jsm
@@ +372,3 @@
>        }
> +
> +      return aData[key];

If the comment at https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/Task.jsm (on the General Example, line 18) is not true anymore, can you please edit the documentation and amend it?

Comment 9

[Carmen Jimenez Cabezas]

This code looks good to me, but it doesn't fix all the errors introduces in OperatorApps.jsm by bug 981085. I've opened bug 992589 for that.

Comment 10

[Marco Castelluccio [:marco]]

(In reply to Carmen Jimenez Cabezas from comment #8)
> Comment on attachment 8400892 [details] [diff] [review]
> Alternative patch
> 
> Review of attachment 8400892 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/apps/src/OperatorApps.jsm
> @@ +372,3 @@
> >        }
> > +
> > +      return aData[key];
> 
> If the comment at
> https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/
> Task.jsm (on the General Example, line 18) is not true anymore, can you
> please edit the documentation and amend it?

It is now half-true (because it is true for legacy generator functions). I marked bug 913115 (where the behavior changed) "dev-doc-needed".

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4f5687208984

Friendly reminder that commit messages should state what the patch is doing, not what it's fixing :)
https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4f5687208984

Comment 13

[Marco Castelluccio [:marco]]

Attachment: Patch for Beta

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 981085.
User impact if declined: We can't uplift bug 981085 and so we can't enable a lot of tests on Beta.
Testing completed (on m-c, etc.): This has been an entire cycle on central.
Risk to taking this patch (and alternatives if risky): Basically no risk.
String or IDL/UUID changes made by this patch: None.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a3d8c7c4f462

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/a3d8c7c4f462