[about:home] RTL + HiDPI shows the Restore Previous Session button really large

RESOLVED FIXED in Firefox 31

Status

()

Firefox
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

Trunk
Firefox 31
All
Windows 8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 8400833 [details]
Screenshot of bug

See attached screenshot. When in RTL mode, the icon should be flipped from what it looks like in LTR mode, and it also shouldn't be so huge.
Summary: [about:home] RTL + HiDPI shows the Restore Previous Session button really large and facing the wrong direction → [about:home] RTL + HiDPI shows the Restore Previous Session button really large
Created attachment 8400882 [details] [diff] [review]
Patch
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8400882 - Flags: review?(mdeboer)
Comment on attachment 8400882 [details] [diff] [review]
Patch

LGTM! Verified on OSX retina.
Attachment #8400882 - Flags: review?(mdeboer) → review+
Created attachment 8401888 [details] [diff] [review]
Patch (updated commit message)

Carrying forward r+ from mikedeboer, just updated the commit message.
Attachment #8400882 - Attachment is obsolete: true
Attachment #8401888 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/18857cdcc19c
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/18857cdcc19c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.