991297 - [Tarako][Camera]Camera UI disappear after viewing a video from the filmstrip

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

Description

[Andrew Stole [:astole]]

Attachment: logcat

After viewing a recorded video from the camera app filmstrip, the icons in the camera app disappear. When tapping in the area that the record button normally is a couple times, the icons appear on the bottom and side of the screen.

Repro Steps:
1) Update a Tarako to BuildID: 20140402094402
2) Open the camera app and record a video
3) Select the video from the filmstrip
4) Play the video
5) Select the camera icon to return to the camera app

Actual:
The camera app icons disappear.

Expected:
The icons should still be visible

1.3 Environmental Variables:
Device: Tarako 1.3 MOZ
BuildID: 20140402094402
Gaia: 578fdccea89a88b417d296f8cf20b39099d44be4
Gecko: 34ed4cbc5a59
Version: 28.1
Firmware Version: sp8810

Repro frequency: 100%
See attached: logcat, video

Comment 1

[Jason Smith [:jsmith]]

Does this happen on 1.3 Buri?

Comment 2

[Duane Dixon [:ddixon]]

Unable to reproduce this issue in latest Buri 1.3

Videos can be recorded, selected from filmstrip, played, and camera icon can be selected while playing video.  No malfunctions occur.

1.3 Environmental Variables: 
Device: Buri 1.3 MOZ
BuildID: 20131213004002
Gaia: 888f9df5515a47d2f5806efee77485e05e1e5416
Gecko: dfae9c83bfbc
Version: 28.0a2
Firmware Version: v1.2-device.cfg

Comment 3

[Jason Smith [:jsmith]]

In Tarako - after the icons start malfunctioning, can you still use the operations by the icons? Are they entirely impossible to use?

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

The malfunction is that it should switch to the camera not stay on video.  It stays on video, and you can record another video with that icon.  Switching to camera icon again will switch to camera and you can take a picture.  However you cannot switch to gallery.  See bug 991023

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Going to ni? reporter.  How long a video did you use and did you see the same as I did?

Comment 6

[Andrew Stole [:astole]]

The video I used was about 3 seconds long. The app does stay on video when selecting to return back to camera mode from the filmstrip, but the UI disappears after tapping on the screen so I'm not sure if it is completely the same as you are describing. Please refer to the video attached to the URL link that shows what I experienced to see if it is what you are seeing as well. Thank you.

Comment 7

[Jason Smith [:jsmith]]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #4)
> The malfunction is that it should switch to the camera not stay on video. 
> It stays on video, and you can record another video with that icon. 
> Switching to camera icon again will switch to camera and you can take a
> picture.  However you cannot switch to gallery.  See bug 991023

I don't think that answers my question clearly here in comment 3. Re-adding qawanted for more details.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

After watching the video and then retrying, it seems like there's a lot of memory pressure.  
Tapping on the UI seems to be irresponsive.

With the latest build I had to take a couple of retries in order to get to the bug.

Gaia      718a06816327fcb6a18095f677cfff4b86adc292
Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/9ef12c19ddc9
BuildID   20140416004007
Version   28.1
ro.build.version.incremental=eng.cltbld.20140416.123359
ro.build.date=Wed Apr 16 12:34:05 EDT 2014
Tarako

Comment 9

[thomas tsai]

Is it a dupe to 997019? I can't repro it after the fix.

Comment 10

[Jason Smith [:jsmith]]

Leaving qawanted to confirm comment 9.

Comment 11

[Mike Lien[:mlien]]

I can reproduce this issue with below build, it may not dup to 997019
  Gaia      f0872318d46781bb59d0a13a2e1fffb115b8ca2b
  Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/9ff031daa73c
  BuildID   20140417152301
  Version   28.1

Comment 12

[thomas tsai]

Vincent, can you verify it with Mike?

Comment 13

[Mike Lien[:mlien]]

Attachment: logcat_20140421.txt

update STR
1. Launch Camera app
2. Record a video
3. Select video from the filmstrip
4. Play video then pause (must don't play to the end)
5. Select camera icon to return to the camera app

Gaia      68e072af2348c46fbff8a35d99ff10caeab16880
Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/a8cc1aaec6a3
BuildID   20140420164002
Version   28.1

Comment 14

[Vincent Liu[:vliu]]

(In reply to Mike Lien[:mlien] from comment #13)
> Created attachment 8409516 [details]
> logcat_20140421.txt
> 
> update STR
> 1. Launch Camera app
> 2. Record a video
> 3. Select video from the filmstrip
> 4. Play video then pause (must don't play to the end)
> 5. Select camera icon to return to the camera app
> 
> Gaia      68e072af2348c46fbff8a35d99ff10caeab16880
> Gecko    
> https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/a8cc1aaec6a3
> BuildID   20140420164002
> Version   28.1

I confirmed that I can easily reproduce this issue from these steps. I will sync to last and make sure again.

Comment 15

[Vincent Liu[:vliu]]

Synced to last and the issue still happens.

When the issue happens.
1. Tried rotating the device toward different direction, the icon shows up a little short time.
2. After the icons start malfunctioning, I can still use the operations by the icons.

Hi Evelyn,
It seems the icon visibility got malfunctioning in gaia after some operations. Can you please assign one to take a detailed look? I can help to offer any info on Gecko/Gonk part if need. Thanks.

Comment 16

[Vincent Liu[:vliu]]

Hi John,

Based on the Comment 15, can you please help me to have a look for what's going on in gaia part? Thanks.

Comment 17

[Vincent Liu[:vliu]]

Hi dwi2,

Can you help me to take a look based on the Comment 15? Thanks.

Comment 18

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: weird_icon_on_leftside.png

Hi Vincent,
I get a screenshot of it. I also examine the situation with app manager, the DOM structure and style of the malfunction icons seems quite normal. 

It could be a repaint issue. We need graphic experts to look at it.

Comment 19

[Vincent Liu[:vliu]]

Hi Peter,

Based on Comment 18, could you please have a look? Thanks

Comment 20

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: 991297.MOV

This is a video I recorded when bug reproduced. You can see from the upper left corner, camera display correctly for a very short time but goes back abnormal quickly.

Comment 21

[Peter Chang[:pchang]]

Solomon, please help check this issue.

Comment 22

[thomas tsai]

Hi Solomon: any new finding?

Comment 23

[Solomon Chiu [:schiu]]

The width/height of UI layer changes to 0 when issue occurs. Still checking the reason of size changing.

Comment 24

[thomas tsai]

If FPS counter is enabled to reproduce the problem, the area of FPS counter will be corrupted. Can the graphics driver engineer use GPU profiling tool(or ARM DS5) to check if the texture that OpenGL managed being corrupted or not.

Comment 25

[James Zhang (Spreadtrum)]

(In reply to thomas tsai from comment #24)
> If FPS counter is enabled to reproduce the problem, the area of FPS counter
> will be corrupted. Can the graphics driver engineer use GPU profiling
> tool(or ARM DS5) to check if the texture that OpenGL managed being corrupted
> or not.

I don't think we need gpu driver engineer now. Dafeng, please check this issue.

Comment 26

[Solomon Chiu [:schiu]]

Tzu-lin, 

As we discussed yesterday, would you please help to make a debug build which has a translucent button placed on UI? Let's check the repainting behavior based on your build.

Thanks.

Comment 27

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: test patch: transparent-overlay

This is the test patch which shows the camera switch button and use it to show a dummy overlay. The overlay has semi-transparent background which force repaints everything when it shows up. That confirms that UIs are all correct after repainting.

Please note the overlay automatically hides itself after 1sec. If we want to have longer overlay, we can change the time at line 523.

Comment 28

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: non-transparent-overlay.patch

This is the second test patch whose overlay is not transparent. That means everything will be force repaint after the overlay is hidden.

With the semi-transparent version, the UIs are correctly until user taps screen to show/hide filmstrip.

Unlike semi-transparent version, the UI works permanently after the overlay is hidden, like the shown of preview page.

Comment 29

[David Flanagan [:djf]]

Attachment: link to patch on github

John or Solomon,

Would one of you review this patch, please?

This patch fixes the bug by completely stopping the camera stream when we go into preview mode and then restarting it when we leave preview mode. I'm not sure why this fixes the bug, but I think that keeping the stream running when previewing photos and videos was the wrong thing to do anyway.

I've also added code to show a spinner while the camera is starting up and whenever we restart the camera stream.

I don't know what the underlying graphics bug was. Presumably related to having two video elements (one for camera viewfinder and one for playing back a recorded video) running at the same time.  But this does solve the bug and makes the app more robust anyway.

Comment 30

[David Flanagan [:djf]]

Comment on attachment 8415529 [details] [review]
link to patch on github

Justin,

The logical reviewers for this patch are the guys in Taipei who have been working on it. But Taipei is closed for May day, and it is 1.3T+ bug, and it is a pretty small patch, so I thought maybe you could review it instead, if you have time.

I'm leaving the r? for John and Solomon in case they happen to be online Thursday.  (Its a simple patch that only needs one review. I'm just not sure who the best reviewer is.)

Comment 31

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8415529 [details] [review]
link to patch on github

Looks good to me, pretty simple. My only comment was regarding the use of the `hidden` property on the viewfinder DOM element. I wasn't aware that setting it would have any effect, but apparently it does! Learned something new today :-)

Comment 32

[David Flanagan [:djf]]

Landed on v1.3t: https://github.com/mozilla-b2g/gaia/commit/f80f0611931c8d68fb5edd42f83c32bf572efdbf

The camera app in 1.4 and master is completely different and I don't think this bug appears in those branches.

I'm going to close this.  John: if you want to keep investigating the underlying graphics issue I suppose you should open a new bug.

Comment 33

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8415529 [details] [review]
link to patch on github

Thanks, I will file another bug for graphic issue.

Comment 34

[Solomon Chiu [:schiu]]

Comment on attachment 8415529 [details] [review]
link to patch on github

Sorry for late reply due to I had a leave during 5/1 to 5/5.

Comment 35

[Roland Kunkel [:RolandK]]

Following the STR in comment #13 I am unable to reproduce the issue, verified as fixed with latest v1.3 Tarako build:

v1.3T Environmental Variables:
Device: Tarako v1.3T MOZ RIL
BuildID: 20140523014001
Gaia: e76fc9fc64a027d84b2ec311fc624f4c3459dca9
Gecko: 52c1f97caee9
Version: 28.1
Firmware Version: SP6821A-Gonk-4.0-5-12