991331 - Add MOZ_COUNT_CTOR/DTOR to LinkedListElement

Status: NEW

(Core :: MFBT, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

We should track these.

Comment 1

[(no longer active)]

Yeah, I have a list of MFBT bugs to file about these kinds of issues.  This was one of them.

We can use a variant of my hack for this stuff as well, which would cover all of the libxul usage.  Or we can spend some time to figure out how to move the underlying stuff to somewhere that can be shared between MFBT and XPCOM.  The latter takes a considerable amount of time.

How urgent is this Kyle?

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

They also need owning-thread assertions. We would have caught at least one bug easily instead of having to grok intermittent orange logs.

Comment 3

[(no longer active)]

(In reply to comment #2)
> They also need owning-thread assertions. We would have caught at least one bug
> easily instead of having to grok intermittent orange logs.

Yes, also on my list of the stuff to file...

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Of course then we have to teach mfbt about threads...

Comment 5

[Andrew McCreight [:mccr8]]

(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #3)
> Yes, also on my list of the stuff to file...

FWIW, I have now filed this as bug 991710.

Comment 6

[Andrew McCreight [:mccr8]]

The bundle cache CTOR/DTOR stuff should be reverted when this lands: https://hg.mozilla.org/integration/mozilla-inbound/rev/36879243d685

Comment 7

[Andrew McCreight [:mccr8]]

This is probably still a good idea.