99135 - Memory leak of 41 bytes from 1 block allocated in nsAbCardProperty::SetMailListURI

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

MLK: Memory leak of 41 bytes from 1 block allocated in PL_strdup
        Distribution of leaked blocks
                41 bytes from 1 block of 41 bytes (0x0ecf9e28) 
        Allocation location
            malloc+0xc           [dbgheap.c:129 ip=0x002e3c3c]
            PL_strdup+0x75       [.\../../../../lib/libc/src/strdup.c:46
ip=0x004c15a5]
            nsCRT::strdup(char const*)+0x24 [.\..\..\dist\include\nsCRT.h:167
ip=0x1000e8c4]
            nsAbCardProperty::SetMailListURI(char const*)+0x81
[c:\moz_src\mozilla\mailnews\addrbook\src\nsAbCardProperty.cpp:144 ip=0x0fb89591]
            nsAddrDatabase::CreateABListCard(nsIMdbRow *,nsIAbCard * *)+0x6f7
[c:\moz_src\mozilla\mailnews\addrbook\src\nsAddrDatabase.cpp:3792 ip=0x0fbcd017]
            nsAddrDBEnumerator::CurrentItem(nsISupports * *)+0xe4
[c:\moz_src\mozilla\mailnews\addrbook\src\nsAddrDatabase.cpp:3484 ip=0x0fbca5c4]
            nsAbAutoCompleteSession::SearchCards(nsIAbDirectory
*,nsAbAutoCompleteSearchString *,nsIAutoCompleteResults *)+0x2d3
[c:\moz_src\mozilla\mailnews\addrbook\src\nsAbAutoCompleteSession.cpp:355
ip=0x0fbd9e73]
           
nsAbAutoCompleteSession::SearchDirectory(nsString&,nsAbAutoCompleteSearchString
*,nsIAutoCompleteResults *,int)+0x644
[c:\moz_src\mozilla\mailnews\addrbook\src\nsAbAutoCompleteSession.cpp:456
ip=0x0fbdba24]
           
nsAbAutoCompleteSession::SearchDirectory(nsString&,nsAbAutoCompleteSearchString
*,nsIAutoCompleteResults *,int)+0xc31
[c:\moz_src\mozilla\mailnews\addrbook\src\nsAbAutoCompleteSession.cpp:481
ip=0x0fbdc011]
            nsAbAutoCompleteSession::OnStartLookup(WORD
const*,nsIAutoCompleteResults *,nsIAutoCompleteListener *)+0x6c6
[c:\moz_src\mozilla\mailnews\addrbook\src\nsAbAutoCompleteSession.cpp:598
ip=0x0fbdd586]

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

changing qa over to myself.

Comment 2

[David :Bienvenu]

taking.

Comment 3

[David :Bienvenu]

fixed, here's patch:

C:\six5\mozilla\mailnews\addrbook\src>cvs diff nsAbCardProperty.cpp
Index: nsAbCardProperty.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/addrbook/src/nsAbCardProperty.cpp,v
retrieving revision 1.44
diff -r1.44 nsAbCardProperty.cpp
72a73
>   PR_FREEIF(m_MailListURI);

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED using the latest tip build on Windows 2000.

I ran mozilla.exe -addressbook, scrolled and opened the new card window.

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Wait, I need to verify that using -compose.  I'll re-verify it. 

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

This is fixed, using -compose, too.