99136 - Remove nsIEnumerator interface from nsIEnumerator.idl

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Doug Turner (:dougt)]

Remove nsIEnumerator interface from nsIEnumerator.idl and rename nsISimpleEnumerator

Comment 1

[Doug Turner (:dougt)]

Attachment: proposed patch v.1

Comment 2

[Doug Turner (:dougt)]

Patch move nsISimpleEnumerator to a new IDL nsISimpleEnumerator.idl.  

I am #including nsISimpleEnumerator directly from nsIEnumerator.idl since this
reduces the patch considerably and since nsIEnumerator.idl is not a public
interface, I don't think anyone will have a problem to adding an c #included to it.

Comment 3

[Doug Turner (:dougt)]

reviews please.  Note that this may be the wrong way to do it: Maybe we should
keep the frozen interface in nsIEnumerator.idl and move the unfrozen stuff out
of it.

Comment 4

[rpotts (gone)]

hey doug,

i don't feel strongly one way or the other about the name (nsIEnumerator.idl vs
nsISimpleEnumerator.idl)...  as long as all of the public include files are
fixed up to *only* include the "simple" one :-)

-- rick

Comment 5

[rpotts (gone)]

Comment on attachment 54729 [details] [diff] [review]
proposed patch v.1

r/sr=[e-mail]

Comment 6

[Alec Flett]

Comment on attachment 54729 [details] [diff] [review]
proposed patch v.1

sr=alecf

Comment 7

[Doug Turner (:dougt)]

Fix checked in.

Comment 8

[Mike Kaply [:mkaply]]

Isn't the fact that there are now two nsISimpleEnumerator.h's in the build, one 
static, one generated, bad?

At least in the Os/2 case, it appears we are including the wrong one because we 
are going for the local one before the dist one.

Comment 9

[John Bandhauer]

Yes, certainly nsISimpleEnumerator.h should be removed.
Reopening this bug until that is done

Comment 10

[Mike Kaply [:mkaply]]

Attachment: Remove the H file and remove it from exports

Comment 11

[Mike Kaply [:mkaply]]

Thanks to dbaron for removing the stuff I forgot. This is gone now and trees are 
green.