Closed Bug 991366 Opened 6 years ago Closed 5 years ago

New Wallpapers for v.2 to compliment the new Vertical Homescreen

Categories

(Firefox OS Graveyard :: Gaia::Wallpaper, defect, P1)

x86
macOS
defect

Tracking

(blocking-b2g:-, feature-b2g:2.0, b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S3 (6june)
blocking-b2g -
feature-b2g 2.0
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: padamczyk, Assigned: kgrandon)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, bokken,[p=3])

User Story

The addition of new wallpapers to compliment the new homescreen and echo the changes of v.2. The visual design team will create these and add them to the bug.

We will also re-evaluate all the wallpapers and remove ones that don't align with the current designs.

Attachments

(6 files, 9 obsolete files)

1.69 MB, application/zip
Details
3.57 MB, application/zip
Details
3.77 MB, application/zip
Details
7.63 MB, application/zip
Details
4.67 MB, application/zip
Details
46 bytes, text/x-github-pull-request
pla
: review+
padamczyk
: review+
Details | Review
The addition of new wallpapers to compliment the new homescreen and echo the changes of v.2. The visual design team will create these and add them to the bug.
Assignee: nobody → padamczyk
Blocks: 980002
User Story: (updated)
Whiteboard: ux-tracking, visual design, visual-tracking, bokken
No longer blocks: vertical-homescreen
Summary: New Wallpapers for v.2 to compliment the new Homescreen → New Wallpapers for v.2 to compliment the new Vertical Homescreen
blocking-b2g: --- → 2.0?
Not a blocker, but the work seems to be targeted for 2.0. 

Adding swilkes to confirm and put this in the right 2.0 sprint milestone
blocking-b2g: 2.0? → -
Flags: needinfo?(swilkes)
Flags: needinfo?(padamczyk)
Whiteboard: ux-tracking, visual design, visual-tracking, bokken → ux-tracking, visual design, visual-tracking, bokken,[p=3]
Added Milestone. Patryk, please confirm that we'll have sufficient visual design done to get this into the implementation sprint noted here, which starts May 23. Thanks!
Flags: needinfo?(swilkes)
Target Milestone: --- → 2.0 S2 (23may)
Hi Peter - please update with the latest. Sprint 2 started yesterday so I want to make sure this work is ready for implementation. Thanks!
Flags: needinfo?(padamczyk) → needinfo?(pla)
Hi Stephany,

When I talked to Peter Dolanjski about this last month, he said that final wallpaper assets were to be delivered no later than June 6, but ideally a week earlier, so I've been targetting May 30th as the delivery date.

The current state for them is that they are not fully done.  The bulk of the work on them will be done next week, with the following week used to finalize and deliver them.

Does that work?
Flags: needinfo?(pla)
Assignee: padamczyk → pla
Priority: -- → P1
feature-b2g: --- → 2.0
Can we update the target milestone since sprint 2 was passed and this is still open? Thanks.
(In reply to Kevin Hu [:khu] from comment #5)
> Can we update the target milestone since sprint 2 was passed and this is
> still open? Thanks.

Hi Kevin,

The deadline was yesterday, but I needed a few additional hours to complete this.  So please do not change target milestone.  Uploading wallpapers...
Attached file 320x480.zip (obsolete) —
Wallpapers @ 320x480.

Please remove all old wallpapers from 1.4 and earlier and replace with these.
Attached file 480x800.zip (obsolete) —
Wallpapers @ 480x800.

Please remove all old wallpapers from 1.4 and earlier and replace with these.
Attached file 480x854.zip (obsolete) —
Wallpapers @ 480x854.

Please remove all old wallpapers from 1.4 and earlier and replace with these.
Attached file 540x960.zip (obsolete) —
Wallpapers @ 540x960.

Please remove all old wallpapers from 1.4 and earlier and replace with these.
Attached file 720x1280.zip (obsolete) —
Wallpapers @ 720x1280.

Please remove all old wallpapers from 1.4 and earlier and replace with these.
Kevin,

Can you please set the default wallpaper as 'Illus_Flow1_Orange'?  Thanks!
See above comment.
Flags: needinfo?(kgrandon)
Sounds good. Taking this bug to work on the patch. Thanks!
Assignee: pla → kgrandon
Status: NEW → ASSIGNED
Flags: needinfo?(kgrandon)
Target Milestone: 2.0 S2 (23may) → 2.0 S3 (6june)
Hey Peter - Looking through these there's a few problems with naming consistency (or missing ones perhaps?).

For example, we have smaller versions of Flat_Green, but these do not exist in larger formats. (Maybe it's the same as "Flat_Minty"?

Also can we remove "Wallpaper" from the name of the file if they already exist. E.g., we have FX_Stance and FX_Stance_Wallpaper in the various zip files.

Basically all names need to be the same for all of the sizes. I could write a script to migrate them, but I would probably still need mappings from you, and I think it would be better if you could just give me the full set, with uniform names. It also might help future releases when we need to update the wallpapers again. Thanks!
Flags: needinfo?(pla)
Attached file 320x480.zip
Fixed Naming.
Attachment #8432114 - Attachment is obsolete: true
Flags: needinfo?(pla)
Attached file 480x800.zip
Fixed Naming.
Attachment #8432115 - Attachment is obsolete: true
Attached file 480x854.zip (obsolete) —
Fixed Naming.
Attached file 480x854.zip (obsolete) —
Fixed Naming.
Attachment #8432116 - Attachment is obsolete: true
Attached file 480x854.zip
Fixed Naming.
Attachment #8432490 - Attachment is obsolete: true
Attachment #8432491 - Attachment is obsolete: true
Attached file 540x960.zip (obsolete) —
Fixed Naming.
Attached file 720x1280.zip (obsolete) —
Fixed Naming.
Attached file 720x1280.zip
Fixed Naming.
Attachment #8432118 - Attachment is obsolete: true
Attachment #8432494 - Attachment is obsolete: true
Attached file 540x960.zip
Fixed Naming.
Attachment #8432117 - Attachment is obsolete: true
Attachment #8432493 - Attachment is obsolete: true
(In reply to Kevin Grandon :kgrandon from comment #15)

Hey Kevin,

Sorry for the screwy multiple uploads.  I was in a hurry and forgot to obsolete stuff or uploaded twice, etc.  It should be all fixed and properlly obsoleting the old ones now.

The naming should be fixed.  Green is indeed supposed to be called Minty, and I removed the 'Wallpaper' suffix.

Note that for the Flat_ ones, some have an FFOS in front of the colour - I did this so they show up first (assuming it's sorted alphabetically).

Let me know if there are any problems.

> Hey Peter - Looking through these there's a few problems with naming
> consistency (or missing ones perhaps?).
> 
> For example, we have smaller versions of Flat_Green, but these do not exist
> in larger formats. (Maybe it's the same as "Flat_Minty"?
> 
> Also can we remove "Wallpaper" from the name of the file if they already
> exist. E.g., we have FX_Stance and FX_Stance_Wallpaper in the various zip
> files.
> 
> Basically all names need to be the same for all of the sizes. I could write
> a script to migrate them, but I would probably still need mappings from you,
> and I think it would be better if you could just give me the full set, with
> uniform names. It also might help future releases when we need to update the
> wallpapers again. Thanks!
Looking better, only problem is that I noticed PH_PurpleFlower@1.5x is mis-named. I'll just fix this on my end for now, and hopefully this won't cause problems in the future. Thanks Peter!
Hey Peter, Patryk - 

Being that this is a pretty straightforward image swap - could one of you guys review this? Thanks!
Attachment #8432908 - Flags: review?(pla)
Attachment #8432908 - Flags: review?(padamczyk)
Comment on attachment 8432908 [details] [review]
Pull Request - Update wallpaper images

Hey Kevin,

I asked for the old (currently shipping in 1.4 and earlier) wallpapers to be removed as part of this change, but it appears my original instructions were removed with the obsoleting of my older attachments.  Can you remove the old wallpapers?  So to be clear, remove old wallpapers first, then add my new ones (3 of the branded 'FX' wallpapers will have the same filename as the old ones).

Sorry about the misnamed PH_PurpleFlower.  Sometimes Photoshop doesn't save with extension.
Attachment #8432908 - Flags: review?(pla) → review-
Comment on attachment 8432908 [details] [review]
Pull Request - Update wallpaper images

Peter - not sure I follow you.

I certainly deleted the old wallpapers, then applied your new ones over the top. Which old icons are you seeing there that should not be?
Attachment #8432908 - Flags: review- → review?(pla)
Comment on attachment 8432908 [details] [review]
Pull Request - Update wallpaper images

Sorry Kevin,

You're absolutely right.  This looks correct!
Attachment #8432908 - Flags: review?(pla) → review+
Attachment #8432908 - Flags: review?(padamczyk) → review+
Landed: https://github.com/mozilla-b2g/gaia/commit/a1d1ccfc56f9af8cd4c5995c43e5557d7bee0e33
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
You need to log in before you can comment on or make changes to this bug.