991451 - Suppress clang and gcc warnings in third-party code: Skia

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: suppress-mtransport-warnings.patch

This patch suppresses the following clang and gcc warnings emitted from third-party Skia code that should be fixed upstream and not in our tree:

gfx/skia/trunk/src/opts/opts_check_SSE2.cpp:51:20 [-Wunused-function] unused function 'getcpuid'

gfx/skia/trunk/include/core/SkTypes.h:396:45 [-Wlogical-op] logical 'or' of collectively exhaustive tests is always true
gfx/skia/trunk/src/core/SkDistanceFieldGen.cpp:50:47 [-Wlogical-op] logical 'or' of collectively exhaustive tests is always true
gfx/skia/trunk/src/core/SkDistanceFieldGen.cpp:51:45 [-Wlogical-op] logical 'or' of collectively exhaustive tests is always true

gfx/skia/trunk/src/gpu/GrAAConvexPathRenderer.cpp:533:22 [-Woverloaded-virtual]   by 'virtual void QuadEdgeEffect::GLEffect::emitCode(GrGLFullShaderBuilder*, const GrDrawEffect&, GrGLEffect::EffectKey, char const*, char const*, const TransformedCoordsArray&, const TextureSamplerArray&)'
gfx/skia/trunk/src/gpu/GrAARectRenderer.cpp:46:22 [-Woverloaded-virtual]   by 'virtual void GrAlignedRectEffect::GLEffect::emitCode(GrGLFullShaderBuilder*, const GrDrawEffect&, GrGLEffect::EffectKey, char const*, char const*, const TransformedCoordsArray&, const TextureSamplerArray&)'
gfx/skia/trunk/src/gpu/GrAARectRenderer.cpp:164:22 [-Woverloaded-virtual]   by 'virtual void GrRectEffect::GLEffect::emitCode(GrGLFullShaderBuilder*, const GrDrawEffect&, GrGLEffect::EffectKey, char const*, char const*, const TransformedCoordsArray&, const TextureSamplerArray&)'
gfx/skia/trunk/src/gpu/GrOvalRenderer.cpp:95:22 [-Woverloaded-virtual]   by 'virtual void CircleEdgeEffect::GLEffect::emitCode(GrGLFullShaderBuilder*, const GrDrawEffect&, GrGLEffect::EffectKey, char const*, char const*, const TransformedCoordsArray&, const TextureSamplerArray&)'
gfx/skia/trunk/src/gpu/GrOvalRenderer.cpp:206:22 [-Woverloaded-virtual]   by 'virtual void EllipseEdgeEffect::GLEffect::emitCode(GrGLFullShaderBuilder*, const GrDrawEffect&, GrGLEffect::EffectKey, char const*, char const*, const TransformedCoordsArray&, const TextureSamplerArray&)'
gfx/skia/trunk/src/gpu/GrOvalRenderer.cpp:346:22 [-Woverloaded-virtual]   by 'virtual void DIEllipseEdgeEffect::GLEffect::emitCode(GrGLFullShaderBuilder*, const GrDrawEffect&, GrGLEffect::EffectKey, char const*, char const*, const TransformedCoordsArray&, const TextureSamplerArray&)'
gfx/skia/trunk/src/gpu/effects/GrBezierEffect.cpp:19:18 [-Woverloaded-virtual]   by 'virtual void GrGLConicEffect::emitCode(GrGLFullShaderBuilder*, const GrDrawEffect&, GrGLEffect::EffectKey, char const*, char const*, const TransformedCoordsArray&, const TextureSamplerArray&)'
gfx/skia/trunk/src/gpu/effects/GrBezierEffect.cpp:167:18 [-Woverloaded-virtual]   by 'virtual void GrGLQuadEffect::emitCode(GrGLFullShaderBuilder*, const GrDrawEffect&, GrGLEffect::EffectKey, char const*, char const*, const TransformedCoordsArray&, const TextureSamplerArray&)'
gfx/skia/trunk/src/gpu/effects/GrBezierEffect.cpp:305:18 [-Woverloaded-virtual]   by 'virtual void GrGLCubicEffect::emitCode(GrGLFullShaderBuilder*, const GrDrawEffect&, GrGLEffect::EffectKey, char const*, char const*, const TransformedCoordsArray&, const TextureSamplerArray&)'
gfx/skia/trunk/src/gpu/effects/GrCustomCoordsTextureEffect.cpp:21:18 [-Woverloaded-virtual]   by 'virtual void GrGLCustomCoordsTextureEffect::emitCode(GrGLFullShaderBuilder*, const GrDrawEffect&, GrGLEffect::EffectKey, char const*, char const*, const TransformedCoordsArray&, const TextureSamplerArray&)'
gfx/skia/trunk/src/gpu/effects/GrDistanceFieldTextureEffect.cpp:28:18 [-Woverloaded-virtual]   by 'virtual void GrGLDistanceFieldTextureEffect::emitCode(GrGLFullShaderBuilder*, const GrDrawEffect&, GrGLEffect::EffectKey, char const*, char const*, const TransformedCoordsArray&, const TextureSamplerArray&)'
gfx/skia/trunk/src/gpu/gl/GrGLVertexEffect.h:38:18 [-Woverloaded-virtual] 'virtual void GrGLVertexEffect::emitCode(GrGLShaderBuilder*, const GrDrawEffect&, GrGLEffect::EffectKey, char const*, char const*, const TransformedCoordsArray&, const TextureSamplerArray&)' was hidden

Comment 1

[Benoit Girard (:BenWa)]

Comment on attachment 8401054 [details] [diff] [review]
suppress-mtransport-warnings.patch

Review of attachment 8401054 [details] [diff] [review]:
-----------------------------------------------------------------

Forwarding to George who's a better owner for Skia changes.

Comment 2

[George Wright (:gw280) (needinfo me!)]

This patch doesn't appear to change Skia code?

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: suppress-skia-warnings.patch

Oops! Sorry, George. I attached the wrong patch.

Comment 4

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 8401106 [details] [diff] [review]
suppress-skia-warnings.patch

Review of attachment 8401106 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable, but can you please add the relevant stuff to generate_mozbuild as well? moz.build is generated by that script.

Comment 5

[Chris Peterson [:cpeterson]]

I landed the patch with the requested fixes for generate_mozbuild.py:
https://hg.mozilla.org/integration/mozilla-inbound/rev/14b5fbfa2163

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/14b5fbfa2163