991459 - [Tarako][Gaia]Unzip settings application.zip get unzip error

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[Mike Lien[:mlien]]

[Device]
  Tarako
---------------------------------------------
[Reproduction build] - V1.3T
  Gaia      c418ec10d1e1d53c6757ad12b2320c204808d251
  Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/36b1279ef6df
  BuildID   20140402164000
  Version   28.1
---------------------------------------------
[Reproduce Steps]
  1. adb pull /system/b2g/webapps/settings.gaiamobile.org/application.zip
  2. unzip application.zip on GUI
---------------------------------------------
[Expected Result]
  Should unzip normally
---------------------------------------------
[Actual Result]
  It will unzip error

Archive:  /home/$user/application.zip
Zip file size: 2663595 bytes, number of entries: 338
warning [/home/$user/application.zip]:  2636546 extra bytes at beginning or within zipfile
  (attempting to process anyway)
error [/home/$user/application.zip]:  reported length of central directory is
  -2636546 bytes too long (Atari STZip zipfile?  J.H.Holm ZIPSPLIT 1.1
  zipfile?).  Compensating...

Comment 1

[Brian Huang [:brianhuang][:brhuang]]

Mike, What kind of scenario or test case that you need to pull the app out?

Comment 2

[Mike Lien[:mlien]]

this zip error case will case some automation cannot be executed, ex: b2g-perf
now alternatives is pull this broken zip out and refine it then push it back to let automation can be used

Comment 3

[Mike Lien[:mlien]]

(In reply to Mike Lien[:mlien] from comment #2)
> this zip error case will case some automation cannot be executed, ex:
> b2g-perf
> now alternatives is pull this broken zip out and refine it then push it back
> to let automation can be used

update for typo
this zip error case will cause some automation cannot be executed, ex: b2g-perf
now alternatives is pull this broken zip out and refine it then push it back to let automation can be used

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

triage: let's not block the release with this
ni? Evelyn

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Try unzip -ff application.zip and then try unzipping again.

Not sure why we are getting this.

Comment 6

[Evelyn Hung]

Can someone bisect to see which commit cause the problem? I can't think of any change in settings app is related. :(

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

needinfo myself.

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I cannot reproduce. Mike, could you attach the zip file? thanks.

Comment 9

[Mike Lien[:mlien]]

Attachment: application.zip

Comment 10

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

it should be an issue of nsIZipWriter, needinfo Shian-Yow Wu.

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

BTW, I got a warning message but still can uncompress this file with unzip.

Comment 12

[Shian-Yow Wu [:swu]]

This can be reproduced on Tarako when building apps by "make reorder", and doesn't happen when building apps with "make webapp-zip".

Comment 13

[Shian-Yow Wu [:swu]]

The optimizejars.py added in bug 835695 reorders the zip headers in application.zip to make apps load faster.  Such reordering might be complained by some zip programs.
In bug 605524 comment 2, it was suggested to de-optimize the zip package before been used by zip program that doesn't accept such reordering.

Comment 14

[BMO Automation]

Firefox OS is not being worked on