99156 - Freeze nsIProgrammingLanguage

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Doug Turner (:dougt)]

yes, the nsIClassInfo fan-out requires this interface.  Do we have to freeze if
this interface only grows with enum constants?

Comment 1

[John Bandhauer]

I say we can freeze this in the sense that no methods or attributes should ever 
be added. We'd want to stop anyone from doing that! I think we should understand 
that new consts are allowed even though this is considered frozen. Adding 
constants will not break anything. Adjust the rules to the reality.

Comment 2

[Doug Turner (:dougt)]

Attachment: Addes @status line to interface

Comment 3

[Doug Turner (:dougt)]

jband, can you review this patch which freezes this interface?

Comment 4

[Doug Turner (:dougt)]

hold off on that review.  Let me add some comments so that people know what the
hell this interface does. :-)

Comment 5

[Doug Turner (:dougt)]

Index: nsIProgrammingLanguage.idl
===================================================================
RCS file: /cvsroot/mozilla/xpcom/base/nsIProgrammingLanguage.idl,v
retrieving revision 1.3
diff -u -r1.3 nsIProgrammingLanguage.idl
--- nsIProgrammingLanguage.idl	2001/05/09 20:51:53	1.3
+++ nsIProgrammingLanguage.idl	2001/09/13 20:45:19
@@ -41,6 +41,11 @@
 #endif
 %}
 
+/**
+ * Enumeration of Programming Languages
+ * @status FROZEN
+ */
+
 [scriptable, uuid(ea604e90-40ba-11d5-90bb-0010a4e73d9a)]
 interface nsIProgrammingLanguage : nsISupports
 {

can I get a r=, jband?

Comment 6

[John Bandhauer]

r/rs=jband

Comment 7

[rpotts (gone)]

Comment on attachment 49060 [details] [diff] [review]
Addes @status line to interface

r=rpotts

looks good to me.

Comment 8

[Doug Turner (:dougt)]

I checked this in already.