991573 - Change success message for Call Barring and Call Waiting interrogation through MMI

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Beatriz Rodríguez [:brg]]

This is a suggestion of strings improvement in English that provide information through MMI codes about the status of call barring service.

This is not a blocker in 1.3 but a nice improvement for the future if you agree.

1) Interrogation (*#33#)

1.A) If call barring is currently enabled:

Current English translation:  Service was enabled for:
Expected English translation: Service is enabled for:

1.B) If call barring is currently disabled:

Current English translation:  Service has been disabled
Expected English translation: Service is disabled

Comment 1

[Axel Hecht [:Pike]]

Moving over to fx os, this might be good input for the copy review.

Comment 2

[Guillermo López :willyaranda (probably SLOW response)]

Hi,

I was talking with Beatriz and the problem is that there is a single en-US string for two different actions here:

1) Query the operator what is the status of Call barring
2) Query the operator to CHANGE the status of Call barring

In both cases, if the service end up being deactivated, the English string is "Service has been disabled".

So, with my bad English, I think case 1) should something like "Service is disabled" and case 2) "Service has been disabled".

I don't know, but maybe it is the same for the enabled call barring status.

Comment 3

[Guillermo López :willyaranda (probably SLOW response)]

(BTW, the reference URL in transvision: http://transvision.mozfr.org/?recherche=Service+has+been+disabled&repo=gaia&sourcelocale=en-US&locale=es&search_type=strings)

Comment 4

[Matej Novak [:matej]]

(In reply to Axel Hecht [:Pike] from comment #1)
> Moving over to fx os, this might be good input for the copy review.

Thanks, Alex. Also CCing Stephany as she is leading the copy audit.

At a quick look, the proposal in comment 2 looks about right.

Comment 5

[Beatriz Rodríguez [:brg]]

Stephany, per comment 4, is there any chance that this change could be included in 2.0?

Comment 6

[Stephany Wilkes]

We are well past string freeze so likely not, unfortunately.

Comment 7

[David Garcia [:davidg][retired]]

Attachment: github PR

Because the mmiResponse is exactly the same when you query and when you activate/deactivate the service, I'm passing the original mmi command to success handler, to be able to show one message or the other.
I was trying to include test, but the only thing to test is what text is displayed, and I'm not sure that kind of test makes sense.

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 8462467 [details] [review]
github PR

redirecting...

Comment 9

[Anthony Ricaud (:rik)]

Comment on attachment 8462467 [details] [review]
github PR

Re-redirecting to Doug. Doug: If you have doubts about MMI behaviours, please ask.

Comment 10

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8462467 [details] [review]
github PR

I left some comments on the PR. This does need some tests to check that it displays the correct strings. I may have more significant changes after I talk with Gabriele and Anthony about this.

Comment 11

[Gabriele Svelto [:gsvelto]]

Moving this to the right component and marking it as assigned since work is undergoing already.

Comment 12

[David Garcia [:davidg][retired]]

Comment on attachment 8462467 [details] [review]
github PR

Sorted comments from Gsvelto and Doug.
Added some tests

Comment 13

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8462467 [details] [review]
github PR

I left some comments on the PR.

Also, this could use a demo.

Comment 14

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8462467 [details] [review]
github PR

Please refer to bug 1049651 in the TODO comment and then I think we're good to go.

Comment 15

[Doug Sherk (:drs) (inactive)]

Also, please update the title of this bug and the PR to better reflect what changes are actually being made.

Comment 16

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed: https://github.com/mozilla-b2g/gaia/commit/cc60e6582f74a96cbab1edb250fda6f7af8d8c86

Comment 17

[Loli (:lolimartinezcr)]

Tested and working
Flame 
2.1
Gecko-ca5d875
Gaia-fee004d

If call barring is currently enabled and I ask to device status: 
Service is enabled for: ...

If call barring is currently disabled and I ask to device status: 
Service is disabled