991674 - IconRetriever fails to get icon but error callback is not executed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Amir Nissim (:amirn)]

when trying to retrieve the icon for Music2 with:
    IconRetriever.get({
      icon: Music2Icon,
      success: success,
      error: error
    });

neither the success nor the error callbacks are executed, because of this line:
https://github.com/EverythingMe/gaia/blob/master/apps/homescreen/js/icon_retriever.js#L21

(the request is ongoing forever)

after |make reset-gaia| you can see this log message:
E/GeckoConsole( 7619): Content JS ERROR at app://homescreen.gaiamobile.org/js/icon_retriever.js:47 in retrieve: Got an exception when trying to load icon "app://music2.gaiamobile.org/style/icons/60/Music.png +" falling back to cached icon. Exception is:

Comment 1

[Amir Nissim (:amirn)]

Attachment: Github Pull Request

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8402329 [details] [review]
Github Pull Request

Good job mate!

Comment 3

[Amir Nissim (:amirn)]

landed: https://github.com/mozilla-b2g/gaia/commit/fe908a6