Closed Bug 991690 Opened 6 years ago Closed 6 years ago
Remove the classinfo from Event
Non-standard, instances are unavailable from content anyway, no other browsers have this property on the global object. There's no point in exposing it on the global object.
Attachment #8401299 - Flags: review?(bugs)
Comment on attachment 8401299 [details] [diff] [review] patch Doesn't this break all sorts of stuff? How did EventListenerInfo end up to content global. I thought it was only in chrome. Probably my mistake. Anyhow the idea was originally to make it easy to use EventListenerService.
(In reply to Olli Pettay [:smaug] from comment #1) > Doesn't this break all sorts of stuff? At least test_bug448602.html didn't break. https://tbpl.mozilla.org/?tree=Try&rev=c413c640feb4 If the test doesn't catch the error somehow, it should be added to the test. > How did EventListenerInfo end up to content global. I thought it was only > in chrome. Probably my mistake. It will be ChromeOnly if NS_DEFINE_CLASSINFO_DATA is replaced with NS_DEFINE_CHROME_ONLY_CLASSINFO_DATA. But I doubt the global property is needed even in chrome. > Anyhow the idea was originally to make it easy to use EventListenerService. nsIEventListenerInfo is the only interface EventListenerInfo implements, so the interface flattening is not needed.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.