991690 - Remove the classinfo from EventListenerInfo

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: patch

Non-standard, instances are unavailable from content anyway, no other browsers have this property on the global object. There's no point in exposing it on the global object.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8401299 [details] [diff] [review]
patch

Doesn't this break all sorts of stuff?


How did EventListenerInfo end up to content global. I thought it was only
in chrome. Probably my mistake.
Anyhow the idea was originally to make it easy to use EventListenerService.

Comment 2

[Masatoshi Kimura [:emk]]

(In reply to Olli Pettay [:smaug] from comment #1)
> Doesn't this break all sorts of stuff?

At least test_bug448602.html didn't break.
https://tbpl.mozilla.org/?tree=Try&rev=c413c640feb4
If the test doesn't catch the error somehow, it should be added to the test.

> How did EventListenerInfo end up to content global. I thought it was only
> in chrome. Probably my mistake.

It will be ChromeOnly if NS_DEFINE_CLASSINFO_DATA is replaced with NS_DEFINE_CHROME_ONLY_CLASSINFO_DATA. But I doubt the global property is needed even in chrome.

> Anyhow the idea was originally to make it easy to use EventListenerService.

nsIEventListenerInfo is the only interface EventListenerInfo implements, so the interface flattening is not needed.

Comment 3

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3fb71ae9db9a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3fb71ae9db9a

Comment 5

[Kohei Yoshino [:kohei]]

https://developer.mozilla.org/en-US/Firefox/Releases/31/Site_Compatibility