991692 - "TypeError: internals.tracker is undefined" found in green jetpack test runs

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Ed Morley [:emorley]]

eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=37217301&tree=B2g-Inbound

{
TEST-PASS | tests/test-xul-app.test xulapp | platformVersion in range [1.9, *)
TEST-PASS | tests/test-xul-app.test xulapp | 3.6.4 in [3.6.4, 3.6.*)
TEST-PASS | tests/test-xul-app.test xulapp | 1.9.3 not in [1.9.2, 1.9.3)
TEST-END | tests/test-xul-app.test xulapp
An exception occurred.
Traceback (most recent call last):
  File "resource://gre/modules/commonjs/sdk/timers.js", line 40, in notify
    callback.apply(null, args);
  File "resource://gre/modules/commonjs/sdk/test/harness.js", line 233, in cleanup
    loader.unload();
  File "resource://gre/modules/commonjs/sdk/system/unload.js", line 41, in unloadWrapper
    originalDestructor.call(obj, reason);
  File "resource://gre/modules/commonjs/sdk/test/loader.js", line 38, in CustomLoader/wrapper<.unload
    unload(loader, reason);
  File "resource://gre/modules/commonjs/toolkit/loader.js", line 673, in unload
    notifyObservers(subject, 'sdk:loader:destroy', reason);
  File "resource://gre/modules/commonjs/sdk/system/events.js", line 74, in Observer<.observe
    data: data
  File "resource://gre/modules/commonjs/sdk/system/unload.js", line 77, in onunload
    unload(reason);
  File "resource://gre/modules/commonjs/sdk/system/unload.js", line 56, in unload
    observers.forEach(function(observer) {
  File "resource://gre/modules/commonjs/sdk/system/unload.js", line 58, in unload/<
    observer(reason);
  File "resource://gre/modules/commonjs/sdk/system/unload.js", line 67, in 
    unloaders.slice().forEach(function(unloadWrapper) {
  File "resource://gre/modules/commonjs/sdk/system/unload.js", line 68, in 
    unloadWrapper(reason);
  File "resource://gre/modules/commonjs/sdk/system/unload.js", line 41, in unloadWrapper
    originalDestructor.call(obj, reason);
  File "resource://gre/modules/commonjs/sdk/test/loader.js", line 38, in CustomLoader/wrapper<.unload
    unload(loader, reason);
  File "resource://gre/modules/commonjs/toolkit/loader.js", line 673, in unload
    notifyObservers(subject, 'sdk:loader:destroy', reason);
  File "resource://gre/modules/commonjs/sdk/system/events.js", line 74, in Observer<.observe
    data: data
  File "resource://gre/modules/commonjs/sdk/system/unload.js", line 77, in onunload
    unload(reason);
  File "resource://gre/modules/commonjs/sdk/system/unload.js", line 56, in unload
    observers.forEach(function(observer) {
  File "resource://gre/modules/commonjs/sdk/system/unload.js", line 58, in unload/<
    observer(reason);
  File "resource://gre/modules/commonjs/sdk/system/unload.js", line 67, in 
    unloaders.slice().forEach(function(unloadWrapper) {
  File "resource://gre/modules/commonjs/sdk/system/unload.js", line 68, in 
    unloadWrapper(reason);
  File "resource://gre/modules/commonjs/sdk/system/unload.js", line 41, in unloadWrapper
    originalDestructor.call(obj, reason);
  File "resource://gre/modules/commonjs/sdk/core/disposable.js", line 76, in Disposable<.destroy
    unload(this, reason);
  File "resource://gre/modules/commonjs/method/core.js", line 119, in dispatch
    return method.apply(method, arguments)
  File "resource://gre/modules/commonjs/sdk/core/disposable.js", line 114, in 
    unload(disposable);
  File "resource://gre/modules/commonjs/method/core.js", line 119, in dispatch
    return method.apply(method, arguments)
  File "resource://gre/modules/commonjs/sdk/core/disposable.js", line 43, in 
    dispose.define(Object, object => object.dispose());
  File "resource://gre/modules/commonjs/sdk/ui/sidebar.js", line 256, in Sidebar<.dispose
    internals.tracker.unload();
TypeError: internals.tracker is undefined
console.warn: addon-sdk: 444 warnings or errors were logged to the platform's nsIConsoleService, which could be of no consequence; however, they could also be indicative of aberrant behavior.

9970 of 9970 tests passed.
}

Comment 1

[Ed Morley [:emorley]]

First occurred in this merge:
https://tbpl.mozilla.org/?rev=6fa163ff81a3&jobname=jetpack

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?startID=26497&endID=26498

Few things that jump out:
https://hg.mozilla.org/mozilla-central/rev/017e2bfa1550
https://hg.mozilla.org/mozilla-central/rev/51b4d17d0513

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Erik, any ideas?

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1453

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/cd3221439e019aa56dbe659d0b99db6788925e7b
Bug 991692 - "TypeError: internals.tracker is undefined" found in green jetpack test runs

https://github.com/mozilla/addon-sdk/commit/f749d9a3eb535ca11c0d4c24aedb6537dfa58e4b
Merge pull request #1453 from erikvold/991692

Fix Bug 991692 - "TypeError: internals.tracker is undefined" found in green jetpack test runs, r=@jsantell

Comment 5

[Ed Morley [:emorley]]

Thank you for this :-)