991730 - Custom Queries do not work yet

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[[DEACTIVATED] Adrian Gaudebert]

There are 2 problems that, for some reason, I missed during the development of that feature in bug 890946: 

1. The indices that the user sets in the UI are not sent to the middleware. 
2. Results can not be shown because of a JavaScript error.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/a25634d28618c31149525a71678c98da1486d941
Fixes bug 991730 - Fixed custom queries. r=peterbe

Comment 2

[Matt Brandt [:mbrandt]]

This looks important - what are minimal steps to QA?

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

Steps to QA
-----------

1. Go to Super Search
2. Create a search by adding some filters
3. Click the "Customize" button to go to the Custom Query page
4. Verify that there is a query in the main textarea, and it is not the default one (that you can see by the "Custom Query" link at the top)
5. Click the "Search" button and verify that results are returned eventually. 

There is one last problem on stage at the moment, some files related to the Ace editor cannot be found. I'm reopening to fix this with this bug. 

Note that this feature is hidden behind waffle (and thus not yet activated in prod, even if code is there) and behind a new permission, run_custom_queries, that you need to have to access the custom query page. Matt, I have given that permission to you on stage.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/43a19fd7a9138889b629edc7a7c10f578e5f1d2f
Fixes bug 991730 - Fixed theming of ACE editor in non-dev environments. r=peterbe