991813 - [Camera] Zoom Bar jumps on orientation change

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Justin D'Arcangelo [:justindarc]]

When rotating the device while the Zoom Bar is visible on-screen, the Zoom Bar can be seen momentarily in its new location. The expected behavior is for the Zoom Bar to disappear completely in the new orientation until re-activated by the user.

This was previously resolved in bug 985236 and the patch for it is still intact on master. So, I'm assuming something has changed in gecko to cause the previous patch to no longer be effective in preventing this.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (master)

David: Please review. It looks like an additional animation frame is required for enforcing the `0s` transition duration and then re-enabling it again.

Tif: Take a look at this patch on your device and let me know if this resolves the issue for you. You'll have to pull down my branch to test:

git fetch justindarc
git checkout justindarc/bug991813
make install-gaia APP=camera

Comment 2

[David Flanagan [:djf]]

Comment on attachment 8401466 [details] [review]
pull-request (master)

I'm giving r+, but am a little uncomfortable because I don't understand why this works and the old code didn't.  If you understand it, I recommend a comment explaining it.

If you don't understand it, are there simpler ways to achieve the same end?  Like setting display:none and then restoring display:block after a RAF?

Comment 3

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/30b6daf287b4528528338014a874f9f5e54f9351

Needs uplifted to 1.4.

Comment 4

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8401466 [details] [review]
pull-request (master)

patch resolves the jumping issue on rotation

Comment 5

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/f081c694835413aeeb0c7e23c15af625eb4a296e

Comment 6

[sarsenyev]

The bug is no longer reproduces on 1.4 and 1.5 master
The zoom icon disappears completely when rotating the phone until re-activated by user

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140407000203
Gaia: 86de7fcce674ef6196d68e7e23552d219a3d72db
Gecko: 6e028297be14
Version: 30.0a2
Firmware Version: v1.2-device.cfg

1.5 Environmental Variables:
Device: Buri 1.5 Master
BuildID: 20140407040202
Gaia: f1a98bfaa3ab2480945bd7018831fd56c61cdc24
Gecko: 5405d6f4e3c6
Version: 31.0a1
Firmware Version: v1.2-device.cfg