991825 - Marionette unable to tap on a contact in b2g desktop when adding a contact to an sms message

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Bob Silverberg [:bsilverberg]]

test_sms_add_contact.py, which is failing intermittently on TBPL (see bug #982995) is failing continuously for me on desktop. The stack trace is:

TEST-START test_sms_add_contact.py
test_sms_add_contact (test_sms_add_contact.TestSmsAddContact)
Add a contact to a message. ... ERROR

======================================================================
ERROR: None
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/bsilverberg/.virtualenvs/gaia/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette_test.py", line 163, in run
    testMethod()
  File "/Users/bsilverberg/gitRepos/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_add_contact.py", line 33, in test_sms_add_contact
    contacts_app.wait_for_contacts_frame_to_close()
  File "/Users/bsilverberg/gitRepos/gaia/tests/python/gaia-ui-tests/gaiatest/apps/contacts/app.py", line 68, in wait_for_contacts_frame_to_close
    self.wait_for_element_not_present(*self._contacts_frame_locator)
  File "/Users/bsilverberg/gitRepos/gaia/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 35, in wait_for_element_not_present
    lambda m: not m.find_element(by, locator))
  File "/Users/bsilverberg/.virtualenvs/gaia/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/wait.py", line 143, in until
    cause=last_exc)
TimeoutException: TimeoutException: Timed out after 5.02468895912 seconds
TEST-UNEXPECTED-FAIL | test_sms_add_contact.py test_sms_add_contact.TestSmsAddContact.test_sms_add_contact |
----------------------------------------------------------------------
Ran 1 test in 14.201s

FAILED (errors=1)

Watching the test run, it appears that marionette is unable to tap on the contact in the list. I checked the elements visibility from marionette and it reports that the element is visible, yet the click action does nothing. I tried changing the locator to click on a different element, starting with the current one and moving outwards bit by bit, and in every case the tap() method can be called without error, but nothing happens to the UI.

Comment 1

[Bob Silverberg [:bsilverberg]]

The very strange thing about this is that it also seems to be passing consistently on Travis, so I wonder if maybe it's failing for me because I am on OS X. If someone not on OS X could try running the test on desktop that would give us some more information. Perhaps Zac?

Comment 2

[Bob Silverberg [:bsilverberg]]

I was going to submit a pull request to disable the test on TBPL based on what I am seeing, but I am confused by the fact that it seems to pass on desktop elsewhere, so I will put off doing that until someone else gets a chance to take a look.

Comment 3

[Zac C (:zac)]

It is probably just tapping on the element before the click handler is added to the element. Unfortunately that's just about one of the only things we can't check an element has.

Comment 4

[Bob Silverberg [:bsilverberg]]

@Zac: So does that mean we need to add a sleep? Were you able to test this on your system to see what happens? I am baffled by the fact that it fails consistently for me, but passes on Travis and TBPL.

Comment 5

[Zac C (:zac)]

I didn't test locally but the symptoms seem very similar to problems we've seen before where the click/tap is just too fast. The different behaviour between TBPL/Travis/locally just backs this up further.
In this case it is likely to either end up tapping on the wrong location (you can debug this from the tap log in logcat) or it taps but before the event handler is applied and thus nothing happens (harder to debug).

I'd put a sleep in just after wait_for_contacts(1) and before tapping on the contact item and see how it goes. If it then passes consistently then you can safely blame the wait prior to the tap.

Comment 6

[Zac C (:zac)]

I'll fix this today.

Comment 7

[Zac C (:zac)]

Fixed and has been green on b2g-inbound all day
https://github.com/mozilla-b2g/gaia/commit/70cbd66b51328d209aa53ec6151c5cae8db60af1