991837 - Only enable APZC during reftest-ipc

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: apzc-change

See https://bugzilla.mozilla.org/show_bug.cgi?id=986660#c4.

This patch enables the pref for reftest-ipc from mozharness.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: disable-apzc

This patch disables APZC in reftests.

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 8401477 [details] [diff] [review]
apzc-change

*stamp*

Comment 3

[Aki Sasaki (not active)]

(In reply to Aki Sasaki [:aki] from comment #2)
> Comment on attachment 8401477 [details] [diff] [review]
> apzc-change
> 
> *stamp*

This option needs to be accepted by every tree that runs reftest-ipc, or there will be burning trees.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Do different trees use different versions of mozharness?

Comment 5

[Aki Sasaki (not active)]

All production trees use the production branch of mozharness, so if b2g18 or esr24 (or whatever) has reftest-ipc, they need to accept that option.

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

As far as I know, we've been setting layers.async-pan-zoom.enabled=true in reftests since the FF4 days. So I think we should be fine having the mozharness patch apply to all branches. It just sets the pref in a different way (via mozharness rather than via some in-tree reftest code). Before the reftest-preferences.js patch lands on a given tree, we'll just be setting the option in two different ways, which should be fine.

Comment 7

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Landed the mozharness change.
https://hg.mozilla.org/build/mozharness/rev/69131799d6e8

I'll land the other patch after the next reconfigure.

Comment 8

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/75e0bec11afd

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/75e0bec11afd