Closed
Bug 991837
Opened 10 years ago
Closed 10 years ago
Only enable APZC during reftest-ipc
Categories
(Testing :: Reftest, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla31
People
(Reporter: billm, Assigned: billm)
Details
Attachments
(2 files)
5.06 KB,
patch
|
mozilla
:
review+
|
Details | Diff | Splinter Review |
1.45 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
See https://bugzilla.mozilla.org/show_bug.cgi?id=986660#c4. This patch enables the pref for reftest-ipc from mozharness.
Attachment #8401477 -
Flags: review?(aki)
Assignee | ||
Comment 1•10 years ago
|
||
This patch disables APZC in reftests.
Attachment #8401482 -
Flags: review?(roc)
Comment 2•10 years ago
|
||
Comment on attachment 8401477 [details] [diff] [review] apzc-change *stamp*
Attachment #8401477 -
Flags: review?(aki) → review+
Comment 3•10 years ago
|
||
(In reply to Aki Sasaki [:aki] from comment #2) > Comment on attachment 8401477 [details] [diff] [review] > apzc-change > > *stamp* This option needs to be accepted by every tree that runs reftest-ipc, or there will be burning trees.
Assignee | ||
Comment 4•10 years ago
|
||
Do different trees use different versions of mozharness?
Comment 5•10 years ago
|
||
All production trees use the production branch of mozharness, so if b2g18 or esr24 (or whatever) has reftest-ipc, they need to accept that option.
Assignee | ||
Comment 6•10 years ago
|
||
As far as I know, we've been setting layers.async-pan-zoom.enabled=true in reftests since the FF4 days. So I think we should be fine having the mozharness patch apply to all branches. It just sets the pref in a different way (via mozharness rather than via some in-tree reftest code). Before the reftest-preferences.js patch lands on a given tree, we'll just be setting the option in two different ways, which should be fine.
Attachment #8401482 -
Flags: review?(roc) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Landed the mozharness change. https://hg.mozilla.org/build/mozharness/rev/69131799d6e8 I'll land the other patch after the next reconfigure.
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/75e0bec11afd
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/75e0bec11afd
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•