Closed Bug 991907 Opened 10 years ago Closed 10 years ago

checkEmailStatus in FxAccounts.jsm doesn't handle errors

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33
Tracking Status
firefox29 + wontfix
firefox30 + wontfix
firefox31 - affected

People

(Reporter: ckarlof, Assigned: ttaubert)

Details

(Whiteboard: p=5 s=33.1 [qa-])

Attachments

(1 file)

If there's an error, email polling stops. Besides not handling network failures, this doesn't handle 429 errors (too many requests). We might consider this for beta uplift.
My mistake, /recovery_email/status should not return a 429. It could fail for other reasons, e.g.,

1) lack of network, in which case it should continue to try
2) an invalid auth token, in which case it should stop trying
:markh, do you think we should address this before Fx29 general release?
Flags: needinfo?(mhammond)
(In reply to Chris Karlof [:ckarlof] from comment #2)
> :markh, do you think we should address this before Fx29 general release?

Sorry for the delay, but yeah, I guess we should - it would be quite a paper-cut for people who hit it.  Are you able to do a patch in the short(ish) term?
Flags: needinfo?(mhammond)
If we encounter a 401 here, we should probably transition to the "reconnect" UI state.
Seems clear that we're not going to get this in 29 at this point.
Flags: firefox-backlog?
Flags: firefox-backlog? → firefox-backlog+
Gavin - can we get an assignee here if this is to be fixed in FF30 (we're in week 4 of beta so already weaning off the slightly-more-risky landings)?
Flags: needinfo?(gavin.sharp)
I don't know of any evidence suggesting this has posed a problem in practice. Let's target 31.
Flags: needinfo?(gavin.sharp)
31 is fine. I've heard some people via IRC that have run into it.
Whiteboard: p=0 [qa?]
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Whiteboard: p=0 [qa?] → p=5 s=it-32c-31a-30b.3 [qa-]
Gavin, 31 is going to be in beta today. Do you know someone who could work on this bug? Thanks
Flags: needinfo?(gavin.sharp)
Sorry, I wanted to get to this earlier but didn't manage to. I'll work on it this week.
Flags: needinfo?(gavin.sharp)
Whiteboard: p=5 s=it-32c-31a-30b.3 [qa-] → p=5 s=33.1 [qa-]
We should fix this (and perhaps uplift), but I don't think we need to track it for 31 specifically.
Attachment #8440595 - Flags: review?(mhammond) → review+
https://hg.mozilla.org/mozilla-central/rev/6ee2566596f8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: