Closed
Bug 991928
Opened 11 years ago
Closed 11 years ago
Add check for chrome pages to the "XUL box for %1$S element contained an inline %2$S child..." warning
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: jwalker, Assigned: dbaron)
Details
Attachments
(1 file)
|
1.75 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
The call to nsContentUtils::ReportToConsole in nsCSSFrameConstructor.cpp [1] is worded in a way which has scared people who stray into developer tools by mistake [2]. It's not clear how frequently this happens, but it's probably something that's easy to fix.
We should restrict this console message to chrome rather than web pages.
[1]: https://mxr.mozilla.org/mozilla-central/source/layout/base/nsCSSFrameConstructor.cpp#9445
[2]: https://twitter.com/neave/status/415533230579019777/photo/1
|
Reporter | |
Comment 1•11 years ago
|
||
See also the discussion in bug 991734 comment 7 and on.
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8401688 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8401688 [details] [diff] [review]
Make warning about wrapping XUL boxes chrome-only
r=me
Attachment #8401688 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•