991951 - [B2G][FTU] Some external links on 'About Firefox OS' are not selectable

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Josh Schmitt [Joshs]]

Attachment: FTU.mpeg

Description:
On the 'About Firefox OS page', the external links 'www.mozilla.org/telemety/' and 'www.mozilla.org/privacy/ are not selectable.

Repro Steps:
1) Updated Buri to BuildID: 20140403040201
2) Flash or reset to start FTU process
3) Select 'Next' and turn on Cellular Data
4) Proceed to the 'About Firefox OS' page
5) Select 'Learn More'
6) Select the links 'www.mozilla.org/telemety/' and 'www.mozilla.org/privacy/

Actual:
External links 'www.mozilla.org/telemety/' and 'www.mozilla.org/privacy/ are not selectable.

Expected:
External links are selectable and open their correct webpages.

Environmental Variables:
Device: Buri 1.5 MOZ
BuildID: 20140403040201
Gaia: 0e974ff33ba47f3d1e59df1e0ad534f1bbe3ef8a
Gecko: 91be2828f17e
Version: 31.0a1
Firmware Version: V1.2-device.cfg 

Notes:
Repro frequency: 100%
See attached: Video

Comment 1

[Jason Smith [:jsmith]]

What happens on 1.4?

Comment 2

[Cody Roesch [:croesch]]

In the latest Buri v1.4 build, when I run through FTU the External links 'www.mozilla.org/telemety/' and 'www.mozilla.org/privacy/ are selectable and functional. I've retested this 4 times and every time the links work as expected.


Environmental Variables
Device: Buri V1.4 Moz Ril
Build ID: 20140404000202
Gecko: https://hg.mozilla.org/releases/mozilla-aurora/rev/3186bbc50050
Gaia: b4f3b84ec68233a99fd5865c15cfe28aebe26531
Platform Version: 30.0a2
Firmware Version: v1.2-device.cfg

Comment 3

[jcastro]

B2G Inbound regression window

Last Working Environmental Variables:

1.5 Environmental Variables:
Device: buri 1.5 MOZ
BuildID: 20140319000201
Gaia: db2ef2b61c70889533a0837fa3e053d24e95fdea
Gecko: a6476baa3307
Version: 31.0a1
Firmware Version: v1.2-device.cfg

First Broken Environmental Variables:
1.5 Environmental Variables:
Device: buri 1.5 MOZ
BuildID: 20140319053902
Gaia: e0add8a95f4d1ca26f3bf83d32c58cab7a16826b
Gecko: 63a022bb94c6
Version: 31.0a1
Firmware Version: v1.2-device.cfg


Gaia/Gecko Swap Builds:

Last Working Gaia / First Broken Gecko - Issue does NOT occur
Gaia: db2ef2b61c70889533a0837fa3e053d24e95fdea
Gecko: 63a022bb94c6

Last Working Gecko / First Broken Gaia - Issue DOES occur
Gaia: e0add8a95f4d1ca26f3bf83d32c58cab7a16826b
Gecko: a6476baa3307


Push Log Link:

https://github.com/mozilla-b2g/gaia/compare/db2ef2b61c70889533a0837fa3e053d24e95fdea...e0add8a95f4d1ca26f3bf83d32c58cab7a16826b

Comment 4

[Jason Smith [:jsmith]]

Caused by bug 820344.

Comment 5

[Jason Smith [:jsmith]]

We might want to consider backing out bug 820344 here, as this is a blocking regression. Or we can forward fix this quickly.

flod - what do you want to do here?

Comment 6

[Francesco Lodolo [:flod]]

Looking into it (argh, how did I miss this?), will update in a few minutes to see if we need a backout or a quick fix.

Comment 7

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

So many interactions on that bug, I ended up setting the wrong attributes for link and CSS class.

Comment 8

[Fernando Campo (:fcampo)]

Comment on attachment 8403802 [details] [review]
Pull request on Github

Nice, thanks for fixing this, and sorry for it slipping through my first review :(

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/71d1d469b02a5219fb6e0a8ba174ecb77551d4b8

Comment 10

[Francesco Lodolo [:flod]]

Verified on Hamachi master build (20140414)