991997 - x64 Windows should not try to verify MAR files until MARs are signed on that platform.

Status: RESOLVED WONTFIX

(Toolkit :: Application Update, defect)

Description

[Brian R. Bondy [:bbondy]]

Currently all platforms are verifying MAR signatures when the following bugs are applied: (See Bug 991993).

The problem though is that x64 MARs are not currently signed. After bug 730824 they will be.  I suspect that bug 730824 won't land for a while though so we should just disable the MAR checks when on windows and on x64.

Something like this at the top of the verify function should do it:

#if defined(HAVE_64BIT_OS) && defined(XP_WIN)
// Temporarily disabled because of bug 730824
return;
#endif

Comment 1

[Stephen A Pohl [:spohl]]

I'm wondering if http://mxr.mozilla.org/mozilla-central/source/browser/confvars.sh#12 already does this. Will look into it when I get to this bug.

Comment 2

[Brian R. Bondy [:bbondy]]

I think it does but I think one of the lots of patches that need to land changes this logic to turn it all for everything.  I can also pick this up soonish if you want.

Comment 3

[Stephen A Pohl [:spohl]]

I've un-bitrotted all the patches of the dependent bugs, just waiting for try to clear up so I can push the patches and make sure that nothing broke before I upload them. When I look at confvars.sh locally, the logic appears unchanged (so x64 Windows is still not trying to verify the MAR files). But I wonder if the logic should have changed for Linux and Mac, since we want to verify MAR files there... I'll take this over to bug 991993.

Comment 4

[Brian R. Bondy [:bbondy]]

bug 730824 landed so this is no longer valid.