99228 - after connections timed out, you can't make new imap connections.

Status: VERIFIED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[David :Bienvenu]

If you have filled the imap connection cache, by opening five folders, and then
sit and wait for 30 minutes until the connections have timed out, then try to
select one of the five folders again, it won't open - it will just spin. The fix
is to notice that one of the connections in the cache has timed out and
decrement the count of connections in the cache. I'll attach a fix in a sec.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

Comment 2

[Scott MacGregor]

Comment on attachment 48974 [details] [diff] [review]
proposed fix

sr=mscott

Comment 3

[Scott MacGregor]

adding some keyword stuff. We'll want this on the eMojo branch.

Comment 4

[Scott MacGregor]

*** Bug 95947 has been marked as a duplicate of this bug. ***

Comment 5

[David :Bienvenu]

fix checked in (r=sspitzer)

To recreate the bug, select five different folders, then wait for over 30
minutes, then try to select  another folder. Before the fix, the last folder
select should not do anything (e.g., cause any status msgs or network
connections). After the fix, the folder should load fine. This may also be the
cause of some problems Bob Lord reported on mscott...

Comment 6

[Håkan Waara]

Comment on attachment 48974 [details] [diff] [review]
proposed fix

>+        connection = null_nsCOMPtr();
>+        i--; cnt--; // if the connection times out, we'll remove it from the array,

As far as I know, null_nsCOMPtr() is deprecated and should not be used in new code. Instead just assign the pointer nsnull.

Comment 7

[Bob Lord]

Is this checked into the branch yet?  I've been seeing this problem on the 094
branch all week.

Comment 8

[David :Bienvenu]

no, nothing's checked into the branch, because netscape doesn't own the branch yet.

Comment 9

[Scott MacGregor]

ooops this is supposed to stay open until we can check it into the branch.

Comment 10

[Scott MacGregor]

Per the PDT meeting today, this bug is PDT+.

Comment 11

[Jaime Rodriguez, Jr.]

Mscott - We are ready to take checkins, let's get it in.

Comment 12

[Scott MacGregor]

I think David's stuck in Seattle. I just checked this into the branch for him. 

Comment 13

[Karen Huang]

Verified on Linux 09-27-04-0.9.4 build.
After connections timed out, reselect the 6th folder, msg load without problems.
Will verify on other platforms later.

Comment 14

[Karen Huang]

Verified on WinNT 10-01-05-0.9.4 build
Verified on Mac 10-01-03-0.9.4 build
After connections timed out, select the 6th folder, msg load without problems.
Marking as verified.